Introduce flopenat(3) function.

[oshogbo]

Small fix to man page.

[oshogbo]

Sorry guys for spam ;/
Regenerate with -U99999

[des]

lib/libutil/flopen.3

32 ↗

(On Diff #31069)

only one name per line

lib/libutil/flopen.c

55–57 ↗

(On Diff #31069)

these three lines can remain here, they have no bearing on the varargs code

lib/libutil/libutil.h

96 ↗

(On Diff #31069)

please follow the leading-underscore convention for argument names

[oshogbo]

Update after des@ review.

[emaste]

Should the man page document AT_FDCWD?

This LGTM, with @des's approval.

[des]

I guess you could copy the sentence about AT_FDCWD from openat(2).

BTW, it just occurred to me that you can avoid the duplicate O_CREAT logic by simply passing ap to flopenatm(), which you can then rename vflopenat() (v for va_list, like vfprintf(), instead of m for mode).

[oshogbo]

In D11690#243240, @emaste wrote:

Should the man page document AT_FDCWD?

This LGTM, with @des's approval.

Done.

In D11690#243927, @des wrote:

I guess you could copy the sentence about AT_FDCWD from openat(2).

Done.

In D11690#243927, @des wrote:

BTW, it just occurred to me that you can avoid the duplicate O_CREAT logic by simply passing ap to flopenatm(), which you can then rename vflopenat() (v for va_list, like vfprintf(), instead of m for mode).

Duh ofc... Thanks!!!

[des]

Just a few nits before I approve this :)

lib/libutil/flopen.c

126–127 ↗

(On Diff #31303)

per style(9), ap goes first.

132 ↗

(On Diff #31303)

per style(9), no blank line here.

139–140 ↗

(On Diff #31303)

per style(9), ap goes first.

145 ↗

(On Diff #31303)

per style(9), no blank line here.

[oshogbo]

Style fixes.