Limit descriptors in pidfile
ClosedPublic

Authored by oshogbo on Jul 26 2017, 6:58 PM.

Details

Summary

As suggested by markj@ limit descriptors hidden in pidfile.

This review is depending on:
https://reviews.freebsd.org/D11690
https://reviews.freebsd.org/D11692

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
oshogbo created this revision.Jul 26 2017, 6:58 PM
oshogbo edited the summary of this revision. (Show Details)
markj added inline comments.Jul 26 2017, 8:19 PM
lib/libutil/pidfile.c
33 ↗(On Diff #31223)

This should come before file.h to maintain a sorted order.

193 ↗(On Diff #31223)

Why do we need CAP_SEEK?

oshogbo updated this revision to Diff 31231.Jul 26 2017, 8:29 PM
oshogbo marked an inline comment as done.
oshogbo added inline comments.
lib/libutil/pidfile.c
193 ↗(On Diff #31223)

kern_pwritev as us to do so, but insted of CAP_SEEK and CAP_WRITE we can use just CAP_PWRITE which is equvilant.

markj accepted this revision.Jul 26 2017, 8:30 PM
This revision is now accepted and ready to land.Jul 26 2017, 8:30 PM
cem accepted this revision.Jul 26 2017, 8:44 PM

Style nit: braces seem excessive. Otherwise looks good to me.

This revision was automatically updated to reflect the committed changes.