Page MenuHomeFreeBSD

Limit descriptors in pidfile
ClosedPublic

Authored by oshogbo on Jul 26 2017, 6:58 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Oct 11, 1:12 AM
Unknown Object (File)
Fri, Oct 10, 1:42 AM
Unknown Object (File)
Wed, Oct 8, 4:08 PM
Unknown Object (File)
Wed, Oct 1, 1:22 PM
Unknown Object (File)
Sep 11 2025, 1:10 AM
Unknown Object (File)
Sep 6 2025, 3:30 PM
Unknown Object (File)
Sep 4 2025, 2:19 AM
Unknown Object (File)
Aug 14 2025, 7:04 AM
Subscribers
None

Details

Summary

As suggested by markj@ limit descriptors hidden in pidfile.

This review is depending on:
https://reviews.freebsd.org/D11690
https://reviews.freebsd.org/D11692

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

oshogbo edited the summary of this revision. (Show Details)
lib/libutil/pidfile.c
33 ↗(On Diff #31223)

This should come before file.h to maintain a sorted order.

193 ↗(On Diff #31223)

Why do we need CAP_SEEK?

oshogbo marked an inline comment as done.
oshogbo added inline comments.
lib/libutil/pidfile.c
193 ↗(On Diff #31223)

kern_pwritev as us to do so, but insted of CAP_SEEK and CAP_WRITE we can use just CAP_PWRITE which is equvilant.

This revision is now accepted and ready to land.Jul 26 2017, 8:30 PM

Style nit: braces seem excessive. Otherwise looks good to me.

This revision was automatically updated to reflect the committed changes.