Limit descriptors in pidfile
ClosedPublic
Actions

Authored by oshogbo on Jul 26 2017, 6:58 PM.

Details

Reviewers

emaste
allanjude
markj
cem

Commits

rS322370: Limit descriptors stored in the pidfh structure.

Summary

As suggested by markj@ limit descriptors hidden in pidfile.

This review is depending on:
https://reviews.freebsd.org/D11690
https://reviews.freebsd.org/D11692

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

oshogbo created this revision.Jul 26 2017, 6:58 PM

oshogbo edited the summary of this revision. (Show Details)

markj added inline comments.Jul 26 2017, 8:19 PM

lib/libutil/pidfile.c
33 ↗	(On Diff #31223)	This should come before file.h to maintain a sorted order.
193 ↗	(On Diff #31223)	Why do we need CAP_SEEK?

oshogbo updated this revision to Diff 31231.Jul 26 2017, 8:29 PM

oshogbo marked an inline comment as done.

oshogbo added inline comments.

lib/libutil/pidfile.c
193 ↗	(On Diff #31223)	kern_pwritev as us to do so, but insted of CAP_SEEK and CAP_WRITE we can use just CAP_PWRITE which is equvilant.

markj accepted this revision.Jul 26 2017, 8:30 PM

This revision is now accepted and ready to land.Jul 26 2017, 8:30 PM

Style nit: braces seem excessive. Otherwise looks good to me.

Closed by commit rS322370: Limit descriptors stored in the pidfh structure. (authored by oshogbo). · Explain WhyAug 10 2017, 4:50 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

lib/

libutil/

pidfile.c

30 lines

Diff 31880

View Options

head/lib/libutil/pidfile.c

Limit descriptors in pidfileClosedPublicActions