Page MenuHomeFreeBSD

Remove Unneeded Build of Heimdal for Bootstrap Tools
AbandonedPublic

Authored by cy on Jul 9 2017, 2:21 PM.
Tags
None
Referenced Files
Unknown Object (File)
Jan 7 2024, 4:22 AM
Unknown Object (File)
Aug 2 2023, 9:59 AM
Unknown Object (File)
Jul 15 2023, 4:28 PM
Subscribers

Details

Summary

The following files are built during bootstrap tools but are not ever used during the bootstrap to support the build process itself.

The files are:

  • kerberos5/tools/make-roken
  • kerberos5/lib/libroken
  • kerberos5/lib/libvers \
  • kerberos5/tools/asn1_compile
  • kerberos5/tools/slc
  • usr.bin/compile_et

This differential proposes to remove the above files from the bootstrap tools build process.

Test Plan

This differential has been tested using a tinderbox build. The build passed.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 10410

Event Timeline

I can't think of a better test for this than a tinderbox build.

This revision is now accepted and ready to land.Jul 10 2017, 12:52 AM
ngie requested changes to this revision.Jul 10 2017, 1:22 AM
  • You missed a reference:
$ grep -n _kerberos5_bootstrap_tools Makefile.inc1                                                                                                                                    
1872:_kerberos5_bootstrap_tools= \
1880:.ORDER: ${_kerberos5_bootstrap_tools:C/^/${_bt}-/g}
1895:    ${_kerberos5_bootstrap_tools} \
  • Where are you proposing this be added? To head, or to your project branch?
  • I don't think this will work for the case where you're coming from a non-KERBEROS supporting host to a KERBEROS supported build. Please test out this change as well.
This revision now requires changes to proceed.Jul 10 2017, 1:22 AM

Thanks for pointing out the additional reference. It's been removed locally. I'll post an updated diff after I've tested on a non-kerberos system building/installing w/kerberos. I have a spare partition here to play with.

The intention is to commit this to HEAD. As far as I can tell there is no need to compile kerberos error tables into C source when build-tools are built. The test you suggested will tell whether installing w/kerberos on a non-kerberos system will cause issues.

You are indeed correct. compile_et is used during make includes on a non-kerberos system.