Fix memory corruption while configuring CPU windows on Marvell SoCs
ClosedPublic
Actions

Authored by mw_semihalf.com on May 14 2017, 12:58 AM.

Tags

Referenced Files

	Unknown Object (File)
	Wed, May 1, 9:58 PM

	Unknown Object (File)
	Mon, Apr 29, 10:06 PM

	Unknown Object (File)
	Sat, Apr 27, 3:54 PM

	Unknown Object (File)
	Fri, Apr 26, 1:35 PM

	Unknown Object (File)
	Thu, Apr 25, 7:58 PM

	Unknown Object (File)
	Wed, Apr 24, 7:49 PM

	Unknown Object (File)
	Wed, Apr 24, 6:36 PM

	Unknown Object (File)
	Sat, Apr 20, 6:33 AM

Subscribers

Details

Reviewers

zbb
loos
mmel
• ian

Commits

rS318874: Fix memory corruption while configuring CPU windows on Marvell SoCs

Summary

Resolving CPU windows from localbus entry caused buffer overflow
and memory corruption. Fix wrong indexing and ensure the index
does not exceed table size.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

mw_semihalf.com created this revision.May 14 2017, 12:58 AM

Herald added subscribers: andrew, imp. · View Herald TranscriptMay 14 2017, 12:58 AM

mw_semihalf.com added a parent revision: D10719: Enable proper parsing of nested simlpe-buses on Marvell platforms.May 14 2017, 12:58 AM

mw_semihalf.com added a child revision: D10721: Fix USB3.0 decoding windows on Armada38x.

I think it is easier to use nitems() here.

sys/arm/mv/mv_common.c
2158 ↗	(On Diff #28320)	if (tuples > nitems(cpu_win_tbl)) {
2196 ↗	(On Diff #28320)	if (t >= nitems(cpu_win_tbl)) {

Switched to nitems, thanks for the suggestion.

Closed by commit rS318874: Fix memory corruption while configuring CPU windows on Marvell SoCs (authored by zbb). · Explain WhyMay 25 2017, 2:17 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

arm/

mv/

mv_common.c

12 lines

Diff 28783

View Options

head/sys/arm/mv/mv_common.c

Fix memory corruption while configuring CPU windows on Marvell SoCsClosedPublicActions