Improve busy-wait loop during switch phy access in e6000sw
ClosedPublic
Actions

Authored by mw_semihalf.com on May 14 2017, 12:43 AM.

Tags

Referenced Files

	F161338518: D10713.id.diff
	Thu, Jul 2, 11:10 PM

	Unknown Object (File)
	Wed, Jun 24, 5:43 AM

	Unknown Object (File)
	Mon, Jun 22, 3:14 PM

	Unknown Object (File)
	Tue, Jun 16, 8:48 AM

	Unknown Object (File)
	Wed, Jun 10, 9:13 PM

	Unknown Object (File)
	Tue, Jun 9, 9:22 PM

	Unknown Object (File)
	May 19 2026, 10:22 PM

	Unknown Object (File)
	May 19 2026, 10:21 PM

View All Files

Subscribers

imp

Details

Reviewers

zbb
mmel
loos
fabient
• ian

Commits

rS318521: Improve busy-wait loop during switch phy access in e6000sw

Summary

Hitherto implementation of PHY polling resulted in a risk of an
endless loop and very high occupation of SMI bus. Improve the
operation by limiting the polling tries and adding sleepable
pause.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

mw_semihalf.com created this revision.May 14 2017, 12:43 AM

Herald added a subscriber: imp. · View Herald TranscriptMay 14 2017, 12:43 AM

mw_semihalf.com added a parent revision: D10712: Fix missing unlock in e6000sw driver.May 14 2017, 12:43 AM

mw_semihalf.com added a child revision: D10714: Poll PHY status using internal e6000sw registers.May 14 2017, 12:46 AM

loos accepted this revision.May 17 2017, 10:29 PM

This revision is now accepted and ready to land.May 17 2017, 10:29 PM

Closed by commit rS318521: Improve busy-wait loop during switch phy access in e6000sw (authored by wma). · Explain WhyMay 19 2017, 8:17 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

dev/

etherswitch/

e6000sw/

e6000sw.c

47 lines

Diff 28554

View Options

head/sys/dev/etherswitch/e6000sw/e6000sw.c

Improve busy-wait loop during switch phy access in e6000swClosedPublicActions