Fix broken malloc in e6000sw
ClosedPublic
Actions

Authored by mw_semihalf.com on May 14 2017, 12:40 AM.

Tags

Referenced Files

	F160563005: D10711.id.diff
	Thu, Jun 25, 5:34 PM

	Unknown Object (File)
	Tue, Jun 23, 6:01 PM

	Unknown Object (File)
	Tue, Jun 23, 12:53 AM

	Unknown Object (File)
	Tue, Jun 23, 12:20 AM

	Unknown Object (File)
	Sun, Jun 21, 5:36 PM

	Unknown Object (File)
	Sun, Jun 21, 1:21 AM

	Unknown Object (File)
	Wed, Jun 17, 2:45 AM

	Unknown Object (File)
	Tue, Jun 16, 12:10 PM

View All Files

Subscribers

imp

zbb

Details

Reviewers

fabient
loos
• ian
mmel

Commits

rS318410: Fix broken malloc in e6000sw

Summary

Malloc should always return something when M_WAITOK flag is used,
but keep this code and change flag to M_NOWAIT as it is under a lock
(allows for possible future change). Free ifnet structure to avoid
memory leak on failure.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

mw_semihalf.com created this revision.May 14 2017, 12:40 AM

Herald added a subscriber: imp. · View Herald TranscriptMay 14 2017, 12:40 AM

mw_semihalf.com added a child revision: D10712: Fix missing unlock in e6000sw driver.May 14 2017, 12:41 AM

loos accepted this revision.May 16 2017, 4:05 AM

This revision is now accepted and ready to land.May 16 2017, 4:05 AM

Closed by commit rS318410: Fix broken malloc in e6000sw (authored by zbb). · Explain WhyMay 17 2017, 3:58 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

dev/

etherswitch/

e6000sw/

e6000sw.c

6 lines

Diff 28470

View Options

head/sys/dev/etherswitch/e6000sw/e6000sw.c

Fix broken malloc in e6000swClosedPublicActions