This is a bugfix we use for TwinCAT/BSD. In our environment it's pretty common to isolate single CPU cores from the operating system and let them run application specific code.
Again, I found both of you in the history of the changed file and want to ask for your feedback.
We would like to have this issue solved in upstream FreeBSD to keep our vendor diff small and are willing to improve our implementation, if it doesn't meet your standards.

Fix typos

Thanks for the fast feedback. Yes, we are aware that this patch is not merge able in the current state, but before we put more effort into platforms, which we don't need ourself, we wanted to make sure there is honest interest in the community.
If John has better approach, we would happily volunteer to test his patches ;-).

I found your names in the history of affected files and want to ask you, if this patch would be of interest for upstream FreeBSD. We use it for https://www.beckhoff.com/twincat-bsd/.

This change was merge as commit 5f37265777ec9475a5382654cbf4ae27d927c41a

Agreed, a sane vdev_probe() would be nice. But I have totally no idea how you want to omit cleaning up partially initialized spa/vdev objects without rewriting the whole file. Either some of the current error paths are dead code or things like vdev_init_from_nvlist() have to be replaced.

Yes, but not for all failures. If a label is found in the loop but later the associated data found invalid the vdev_probe() will fail even if there would be another label with better data.

Okay, then I think I got this interface wrong. To me it looked like linuxkpi was intended to run Linux drivers without modification. That's why I thought upstreaming this patch might be of interessed.
If that's not the case, we will just keep it out of tree on our vendor branch. Converting BBAPI to a real FreeBSD driver would be the best option, but currently that's out of budget.
Thanks a lot for your fast feedback.

It's just one driver [1] I care about and it could easily be patched, but vmalloc_exec() is not exported for modules in Linux.
Or do you mean to add something like linux_check_m_prot()?

• release/rc.local: replace reboot button with menu item