Page MenuHomeFreeBSD

p.bruenn_beckhoff.com (Patrick Brünn)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 7 2019, 12:48 PM (68 w, 2 d)

Recent Activity

Wed, May 20

p.bruenn_beckhoff.com added reviewers for D24927: Fix panic in sched_setup_smp when some apics are disabled: kib, mjg.

This is a bugfix we use for TwinCAT/BSD. In our environment it's pretty common to isolate single CPU cores from the operating system and let them run application specific code.
Again, I found both of you in the history of the changed file and want to ask for your feedback.
We would like to have this issue solved in upstream FreeBSD to keep our vendor diff small and are willing to improve our implementation, if it doesn't meet your standards.

Wed, May 20, 3:00 PM
p.bruenn_beckhoff.com updated the diff for D24927: Fix panic in sched_setup_smp when some apics are disabled.

Fix typos

Wed, May 20, 2:51 PM
p.bruenn_beckhoff.com requested review of D24927: Fix panic in sched_setup_smp when some apics are disabled.
Wed, May 20, 2:39 PM
p.bruenn_beckhoff.com added a comment to D24874: Add mutex implementation that uses high irq-level instead of locking interrupts..

Thanks for the fast feedback. Yes, we are aware that this patch is not merge able in the current state, but before we put more effort into platforms, which we don't need ourself, we wanted to make sure there is honest interest in the community.
If John has better approach, we would happily volunteer to test his patches ;-).

Wed, May 20, 8:21 AM

Mon, May 18

p.bruenn_beckhoff.com added reviewers for D24874: Add mutex implementation that uses high irq-level instead of locking interrupts.: ian, mjg, kib.

I found your names in the history of affected files and want to ask you, if this patch would be of interest for upstream FreeBSD. We use it for https://www.beckhoff.com/twincat-bsd/.

Mon, May 18, 8:28 AM
p.bruenn_beckhoff.com requested review of D24874: Add mutex implementation that uses high irq-level instead of locking interrupts..
Mon, May 18, 7:11 AM

Thu, May 14

p.bruenn_beckhoff.com abandoned D20319: stand/zfs: don't fail boot if the first label is broken.

This change was merge as commit 5f37265777ec9475a5382654cbf4ae27d927c41a

Thu, May 14, 12:16 PM
p.bruenn_beckhoff.com abandoned D20303: release/rc.local: prepare "main menu" for more options.
Thu, May 14, 12:11 PM

Jun 5 2019

p.bruenn_beckhoff.com added a comment to D20319: stand/zfs: don't fail boot if the first label is broken.

Agreed, a sane vdev_probe() would be nice. But I have totally no idea how you want to omit cleaning up partially initialized spa/vdev objects without rewriting the whole file. Either some of the current error paths are dead code or things like vdev_init_from_nvlist() have to be replaced.

Jun 5 2019, 2:45 PM

Jun 3 2019

p.bruenn_beckhoff.com added a comment to D20319: stand/zfs: don't fail boot if the first label is broken.

Yes, but not for all failures. If a label is found in the loop but later the associated data found invalid the vdev_probe() will fail even if there would be another label with better data.

Jun 3 2019, 8:14 AM

May 20 2019

p.bruenn_beckhoff.com abandoned D20320: linuxkpi: allow M_EXEC flag for __vmalloc().

Okay, then I think I got this interface wrong. To me it looked like linuxkpi was intended to run Linux drivers without modification. That's why I thought upstreaming this patch might be of interessed.
If that's not the case, we will just keep it out of tree on our vendor branch. Converting BBAPI to a real FreeBSD driver would be the best option, but currently that's out of budget.
Thanks a lot for your fast feedback.

May 20 2019, 8:05 PM
p.bruenn_beckhoff.com added a comment to D20320: linuxkpi: allow M_EXEC flag for __vmalloc().

It's just one driver [1] I care about and it could easily be patched, but vmalloc_exec() is not exported for modules in Linux.
Or do you mean to add something like linux_check_m_prot()?

May 20 2019, 10:27 AM
p.bruenn_beckhoff.com added a reviewer for D20320: linuxkpi: allow M_EXEC flag for __vmalloc(): hselasky.
May 20 2019, 12:25 AM
p.bruenn_beckhoff.com created D20320: linuxkpi: allow M_EXEC flag for __vmalloc().
May 20 2019, 12:24 AM

May 19 2019

p.bruenn_beckhoff.com added a reviewer for D20319: stand/zfs: don't fail boot if the first label is broken: allanjude.
May 19 2019, 11:06 PM
p.bruenn_beckhoff.com added reviewers for D20303: release/rc.local: prepare "main menu" for more options: allanjude, nwhitehorn.
May 19 2019, 11:04 PM
p.bruenn_beckhoff.com created D20319: stand/zfs: don't fail boot if the first label is broken.
May 19 2019, 10:58 PM

May 18 2019

p.bruenn_beckhoff.com updated the diff for D20303: release/rc.local: prepare "main menu" for more options.
  • release/rc.local: replace reboot button with menu item
May 18 2019, 7:12 PM
p.bruenn_beckhoff.com created D20303: release/rc.local: prepare "main menu" for more options.
May 18 2019, 3:03 PM