In D51089#1166071, @mandree wrote:

Thanks for the contribution, but I think this arrives too early (unless I've missed documentation, and I believe I checked the usual places).

The reporter closed the tickets out of frustration:

• https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=284749
• https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=284404

In D51016#1166054, @jrm wrote:

I also lean towards always installing man pages, unless there is some obscene dependency or an upstream toggle. I can also appreciate the value in providing the option.

In D51016#1166022, @diizzy wrote:

I'd value consistency over granuality that adds complexity but that's a personal opinion. If it works and Poudriere is happy I don't have any objections. Mentors?

Mentors?

Bump PORTREVISION

I wonder to what degree @lev is still active because back then I took over all of this Subversion-related ports. Anyone else?

Guys, can you please re-evaluate?

In D51019#1164454, @ehaupt wrote:

The current version does not fetch. If you insist on removing the GL_ stuff (though I don't see the point—aside from dizzy fighting his personal war against convenient git references), please test with make distclean; make fetch. Also, please run portfmt -i on the Makefile.

Run portfmt -i Makefile

Simplify Makefile

In D51016#1164419, @diizzy wrote:

To be fair I'd argue for that unless there a switch/toggle provided by upstream we always install manpages unless they dependencies.

Pinged the maintainer on Bugzilla. Will wait the required two weeks.

@ale @diizzy is this change fine for you?

Bump port revision

In D50960#1163445, @diizzy wrote:

Either way is fine, if you want minimal impact however.... (a bit hackish) :-)

post-install:
.if ${OPSYS} == FreeBSD && ${OSREL:R} < 14 && ${SSL_DEFAULT} == "base"
        @${REINPLACE_CMD} -i '' -e '/ossl-modules/d' ${TMPPLIST}
.endif

@ale, please check again.

In D50960#1163336, @diizzy wrote:

You can also save a few lines by using PLIST_FILES directly and remove lib/ossl-modules/libpkcs11.so and lib/ossl-modules/pkcs11prov.so from pkg-plist
Something like this perhaps?

.if ${OPSYS} == FreeBSD && ${OSREL:R} >= 14 && ${SSL_DEFAULT} != "openssl111"
PLIST_FILES=	lib/ossl-modules/libpkcs11.so \
		lib/ossl-modules/pkcs11prov.so
.endif

Fix typo

Seems like we are in a dead end here?

Port maintainer didn't respond and commit an update himself.

Merged with e4109927e2608347ccdd0667efe02cd8a7fc555e already.

Merged.

Please test thoroughly...

Merged.

In D50932#1162734, @dim wrote:

LGTM

Rebase

Merged.

Improve

In D50803#1159876, @jrm wrote:

Maybe we could refer to the ports rather than the python packages.

While bcrypt remains an acceptable choice for password storage, depending on
your specific use case, you may also want to consider using scrypt (via
standard library or security/py-cryptography) or argon2id (via security/py-argon2-cffi).

Add @jrm's improvements

Address comments from @otis

In D50742#1159138, @dvl wrote:

Thank you for this.

Sort OPTIONS, @garga please check again

In D50775#1158833, @cy wrote:

In D50775#1158797, @michaelo wrote:

In D50775#1158796, @cy wrote:

You can also add approved by maintainer to your commit log message.

This I have, though I am not sure whether I need mentor approval as well along with maintainer approval.

Yes, you also need mentor approval.

@otis , formally OK for you?

In D50775#1158796, @cy wrote:

You can also add approved by maintainer to your commit log message.

Add note in UPDATING

I'll keep this open for a couple of more days to review.

In D50774#1158748, @otis wrote:

Couldn't be WEBSOCKETS also left in place, with the same LIB_DEPENDS and CMAKE_ON as WEBSOCKET, to lower the POLA violation, for some time?

This is a doc change, does this require maintainer approval?