In D45231#1032684, @wosch wrote:

Are you able to follow this up? I'm still unsure when a PR is better than a review, so sorry if I've messed up protocol.

I recycled an old PR 275978, no need to open a new one. I consider the issue as resolved with 37be4197f72ae3a61bd5e93d2ebdc9bd6d09ed21

Yeah, that's cool.. Probably clearer that way.

Oops. Suggested alternative should be "lstat(2)" not "stat(2)" !

I realise that it's my fault for using the weak word "refer" in my original suggestion (I originally wrote "access, eaccess, faccessat will ALWAYS dereference symbolic links. If you need to refer to the symbolic link itself, you'll have to instead use stat(2)") but I think it looks even less suitable in your submission. Would "If the symbolic link itself needs to be referenced..." be better?

I've just confirmed, that your patch (once I add the corresponding "-o" options) allows me to recreate the main functionality of my script with the single command "ps -D'^' -p .... " which is brilliant! - You guessed at my use case before I told you!

Oh! I should have checked the new patch more closely before posting. I see you've added an ascending option!

Your decision is fine to me, but as I mentioned in the email, if your change has been live (in current at least) for a few years, maybe it would cause more problems now to revert it? Especially as the option you chose initially does indeed imply "descendency"

Ahh... So this is why my locale setting is no longer passed through between boxes.

In D34474#781829, @emaste wrote:

Any other feedback?

In D34474#781108, @kevans wrote:

LGTM

I reported on this deprecated element core dumping ( https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=237368 )

Thanks for the quick reply - I don't know if you saw my edit, but for some stupid reason I missed your previous reply when I replied.

In D15801#340849, @delphij wrote:

In D15801#336741, @eadler wrote:

Steal space from RES and SIZE; incrase username

I can't stress how much I hated this. It's 2018, can we do something smarter than assuming the terminal has a fixed width of 80 characters instead of squeezing space unconditionally?