LGTM, yes.

Let me explain what's going on there.

This is landed in 53919f5dd30e939783b85e3763595615f1fe8275

Doesn't virtual_oss rc script already contain BEFORE: sndiod? This forms a cycle.

It turns out that when poudriere jail is run with -b, the PACKAGE_BUILDING isn't defined: https://github.com/freebsd/poudriere/issues/1196

• Add missing close(kq) calls

• More style fixes

In D51549#1208259, @asomers wrote:

But an important question is: what file systems already use this option on Linux?

Style fixes.

Address kib's comments

In D52593#1207066, @christos wrote:

Fine being it uses base sources on CURRENT and audio/virtual_oss on 13.5?

Builds fine on CURRENT and 13.5

LGTM, but I did not test this in Poudriere. @christos let me know if you want me to do it.

All right then, all three ports build fine in Poudriere.

In D52365#1206280, @christos wrote:

This is what we are doing already: https://cgit.freebsd.org/src/tree/usr.sbin/virtual_oss/virtual_oss/main.c#n1639

Or do you mean something else?

In D52365#1206276, @christos wrote:

I suppose if I MFC changes to releng/15.0 and stable/15 we should be safe? This way all releases will share the same code.

I finally managed to build the base part and test this port in Poudriere - it builds successfully.

I'm still getting

This looks great to me, many thanks for gathering this report!

Yes, you're right, the bump wasn't really needed. I misread the change and was thinking that the current package has a wrong shebang.

Thanks!

Firstly, I think there might be an easier way to implement this. If you pass the auto_unmount option to the kernel, then you could add a .d_close method to fuse_device_cdevsw. That method would check for the auto_unmount mount option. If it's set, and the file system isn't already dead (fdata_get_dead), then it would call VOP_UNMOUNT. I think it would work.

Thirdly, in the libfuse component, I think that you could move the statfs and snprintf calls to be before the rfork. Then you could use posix_spawn, which IMHO is less error-prone than rfork.

When the port has GNU_CONFIGURE=yes instead of HAS_CONFIGURE=yes, the framework passes --prefix automatically.
So the change makes sense only if the configure script shipped by sqlite is indeed non-standard.

LGTM, but requires a PORTREVISION bump.

Sorry, ENOTIME. I will try to go over all the oss stuff this Sunday.

I'll leave this comment only in this review, but it applies to all diffs posted by @vladlenpopolitov_list.ru

This was landed in 7d318f76840996d092777d38cf9bdd001ee6afe4

The machinery that is used for building kmods wouldn't work for us. I talked to bapt and it turned out that kmod ports are built using cross-compilation. It works for them, because they have almost zero dependencies, but it won't work for virtual_oss ports.

In D52365#1198719, @christos wrote:

Have you applied D52310?

I finally set up a proper jail for poudriere and carried out the build. This is what I'm getting with poud testport:

===>  Building for virtual_oss_sndio-1600000
[Creating objdir /wrkdirs/usr/ports/audio/virtual_oss_sndio/work/usr/src/amd64.amd64/lib/virtual_oss/sndio...]
--- .depend ---
echo voss_sndio.so: /wrkdirs/usr/ports/audio/virtual_oss_sndio/work/usr/src/amd64.amd64/lib/libsamplerate/libsamplerate_pie.a >> .depend
--- sndio.pico ---
cc -fpic -DPIC   -O2 -pipe  -fstack-protector-strong -fno-strict-aliasing  -fno-common -I/usr/src/usr.sbin/virtual_oss/virtual_oss  -I/usr/src/contrib/libsamplerate  -I/usr/local/include   -MD  -MF.depend.sndio.pico -MTsndio.pico -std=gnu17 -Wno-format-zero-length -fstack-protector-strong -Wsystem-headers -Werror -Wall -Wno-format-y2k -W -Wno-unused-parameter -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wreturn-type -Wcast-qual -Wwrite-strings -Wswitch -Wshadow -Wunused-parameter -Wcast-align -Wchar-subscripts -Wnested-externs -Wold-style-definition -Wno-pointer-sign -Wdate-time -Wmissing-variable-declarations -Wthread-safety -Wno-empty-body -Wno-string-plus-int -Wno-unused-const-variable -Wno-error=unused-but-set-parameter -Wno-error=cast-function-type-mismatch  -Qunused-arguments      -c /usr/src/lib/virtual_oss/sndio/sndio.c -o sndio.pico

All right, figured the installation problem. The following diff should be added to the review:

diff --git a/etc/mtree/BSD.lib32.dist b/etc/mtree/BSD.lib32.dist
index a736a7d58b66..8a3fe9a34714 100644
--- a/etc/mtree/BSD.lib32.dist
+++ b/etc/mtree/BSD.lib32.dist
@@ -21,5 +21,7 @@
         ..
         pkgconfig
         ..
+        virtual_oss
+        ..
     ..
 ..
diff --git a/etc/mtree/BSD.usr.dist b/etc/mtree/BSD.usr.dist
index 7d3a72f43fa1..265f4cfe8753 100644
--- a/etc/mtree/BSD.usr.dist
+++ b/etc/mtree/BSD.usr.dist
@@ -101,6 +101,8 @@
         ..
         ossl-modules
         ..
+        virtual_oss
+        ..
     ..
     libdata
         ldscripts

For now I just fooled the buildsystem by creating those dirs manually.

Making world from scratch with this change applied results in

===> lib/virtual_oss/null (install)
install -U  -s -o root -g wheel -m 444  -C -S  voss_null.so /usr/obj/usr/src/amd64.amd64/tmp/usr/lib/virtual_oss/
install: /usr/obj/usr/src/amd64.amd64/tmp/usr/lib/virtual_oss: No such file or directory
*** [_libinstall] Error code 71

for me.

In D52365#1198141, @makc wrote:

Is it feasible to use the latest virtual_oss for all os releases? Simply using base src does not solve the problem. The official packages are built on the oldest supported release, e.g. right now 14.2-release builds packages for 14.2, 14.3, and 14-stable.