timezone: Move to the XSI/POSIX definition for timezone.
ClosedPublic
Actions

Authored by imp on Mar 8 2024, 6:11 PM.

Details

Reviewers

kib
brooks

Commits

rGa34940a9756a: timezone: Move to the XSI/POSIX definition for timezone.

Summary

The old timezone(3) function has long since been obsolete and has a
fatally flawed interface. Retain this function for compatibility
purposes, but shift to providing the offset from UTC in the timezone
variable, whether or not the timezone observes summer time in the
'daylight' variable. Document the tzname variable that's already been
set. Also make _tztab() static. It's not used in libc (or anywhere in
the tree) and it's not exported as a public dynamic symbol.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

imp requested review of this revision.Mar 8 2024, 6:11 PM

imp created this revision.

Harbormaster completed remote builds in B56518: Diff 135553.Mar 8 2024, 6:11 PM

imp added reviewers: kib, brooks.Mar 8 2024, 6:13 PM

brooks added inline comments.Mar 8 2024, 6:32 PM

lib/libc/gen/Symbol.map
461	Should these go in lib/libc/stdtime/Symbol.map along with tzname since the definitions all come from contrib/tzcode/localtime.c?
lib/libc/gen/tzset.3
36	Should there be an MLINK for discoverability?

update, per Brooks.

Harbormaster completed remote builds in B56546: Diff 135622.Mar 11 2024, 9:33 PM

imp marked 2 inline comments as done.Mar 11 2024, 9:34 PM

imp added inline comments.

lib/libc/gen/Symbol.map
461	Yes. Done.
lib/libc/gen/tzset.3
36	Good idea.

So I don't think I need timezone.3 in the old files stuff...

In D44281#1010587, @imp wrote:

So I don't think I need timezone.3 in the old files stuff...

Yeah, MLINK means you don't need it.

This whole interface is a bit pre-threading, but it is what it is...

lib/libc/gen/Makefile.inc
538	Maybe move to libc/stdtime/Makefile.inc? (Sorry I didn't mention this before.)

This revision is now accepted and ready to land.Mar 11 2024, 10:24 PM

kib accepted this revision.Mar 11 2024, 10:27 PM

imp added inline comments.Mar 11 2024, 10:54 PM

lib/libc/gen/Makefile.inc
538	So tzset.3 is already is already in gen/Makefile.inc. Are you suggesting I remove it from there and move it to stdtime/Makefile.inc?

brooks added inline comments.Mar 11 2024, 11:23 PM

lib/libc/gen/Makefile.inc
538	Oh, I got confused because the implementation is in localtime.c now. I think that tzset.3 should likely to in stdtime since localtime.c is listed there, but leaving things alone or making a separate commit would be fine.