Page MenuHomeFreeBSD
Feed Advanced Search

Sun, Jul 26

neel_neelc.org updated the diff for D25181: Introduce net.inet6.icmp6.reply_from_interface and net.inet6.icmp6.reply_src sysctls.

Sorry for the delay, but I got passing tests! This patch includes them.

Sun, Jul 26, 5:48 AM

Sat, Jul 25

neel_neelc.org updated the diff for D25595: When modifying a route, only allow one of RTF_<BLACKHOLE,REJECT,GATEWAY> to be configured.

With errors upon running rc.d, I realized that we should only do this when modifying.

Sat, Jul 25, 3:43 AM · network

Mon, Jul 20

neel_neelc.org updated the diff for D25595: When modifying a route, only allow one of RTF_<BLACKHOLE,REJECT,GATEWAY> to be configured.
Mon, Jul 20, 4:18 PM · network
neel_neelc.org added inline comments to D25595: When modifying a route, only allow one of RTF_<BLACKHOLE,REJECT,GATEWAY> to be configured.
Mon, Jul 20, 4:18 PM · network

Sun, Jul 19

neel_neelc.org updated the diff for D25595: When modifying a route, only allow one of RTF_<BLACKHOLE,REJECT,GATEWAY> to be configured.

I added tests, they all pass.

Sun, Jul 19, 8:59 PM · network
neel_neelc.org added a comment to D25630: [net0211] Add new capabilities; restrict what can be done in a jail..

I think this broke the build on r363327 with if_an.

Sun, Jul 19, 5:20 PM
neel_neelc.org requested review of D25723: if_an: Unbreak build with PRIV_NET80211_MANAGE->PRIV_NET80211_VAP_MANAGE rename.
Sun, Jul 19, 5:18 PM

Fri, Jul 17

neel_neelc.org added inline comments to D25546: Transition from rtrequest1_fib() to rib_action().
Fri, Jul 17, 8:29 PM · network
neel_neelc.org updated the diff for D25546: Transition from rtrequest1_fib() to rib_action().

Made some suggested revisions.

Fri, Jul 17, 8:28 PM · network
neel_neelc.org updated the diff for D25546: Transition from rtrequest1_fib() to rib_action().
Fri, Jul 17, 4:49 AM · network
neel_neelc.org updated the diff for D25546: Transition from rtrequest1_fib() to rib_action().
Fri, Jul 17, 4:45 AM · network
neel_neelc.org updated the diff for D25546: Transition from rtrequest1_fib() to rib_action().

Remove all variations of rtrequest (rtrequest1_fib, rtrequest_fib, in6_rtrequest, rtrequest_fib) as well.

Fri, Jul 17, 2:49 AM · network
neel_neelc.org added a comment to D25681: if_spppsubr: Define a few LCP options, Recognize (but still reject) multilink PPP config options.

ce(4) for PCI G.703/E1 card,
cp(4) for PCI V.35/RS-232/RS-530/RS-449/X.21/G.703/E1/E3/T3/STS-1 cards,
and cx(4)/ctau(4) for some ISA cards but these do not exist in FreeBSD 13 anymore,
removed by emaste@ recently.

Both ce(4) and cp(4) are i386-only drivers at present.

Such synchronous lines are still in use (here):

  • G.703 is common in phone systems.
  • X.21 for leased lines (with old contracts),
  • E1/E3 for SDH (carrier grade) leases lines.
  • RS-232 is the ordinary serial port, the other RS- are industry specific serials (mainly other voltages)

But you are right: Do we really need a specialized PPP hardware support these days?
Do we really want to run a recent kernel on this antique hardware? It would be a sacrilege.

Normal PPP over serial lines (currently available) does work using ppp(4)

Fri, Jul 17, 1:07 AM · network, transport

Thu, Jul 16

neel_neelc.org abandoned D25681: if_spppsubr: Define a few LCP options, Recognize (but still reject) multilink PPP config options.
Thu, Jul 16, 2:23 AM · network, transport
neel_neelc.org added a comment to D25681: if_spppsubr: Define a few LCP options, Recognize (but still reject) multilink PPP config options.

In case anybody is wondering, the source of the commit is here: https://freshbsd.org/commit/netbsd/src/hRr2tvIj1vj7QI2C

Thu, Jul 16, 2:12 AM · network, transport
neel_neelc.org requested review of D25681: if_spppsubr: Define a few LCP options, Recognize (but still reject) multilink PPP config options.
Thu, Jul 16, 2:12 AM · network, transport
neel_neelc.org updated the diff for D25595: When modifying a route, only allow one of RTF_<BLACKHOLE,REJECT,GATEWAY> to be configured.

Here's the updated code, reduced to a single bitwise operator.

Thu, Jul 16, 1:39 AM · network
neel_neelc.org added inline comments to D25595: When modifying a route, only allow one of RTF_<BLACKHOLE,REJECT,GATEWAY> to be configured.
Thu, Jul 16, 1:37 AM · network

Sun, Jul 12

neel_neelc.org requested review of D25637: Remove net.inet6.ip6.deembed_scopeid sysctl and assume the behavior of net.inet6.ip6.deembed_scopeid=1.
Sun, Jul 12, 6:27 PM

Fri, Jul 10

neel_neelc.org updated the summary of D25607: libalias: Use switch/case statements to compare IPv4 protocol type (TCP/UDP/ICMP).
Fri, Jul 10, 5:09 PM · network
neel_neelc.org added a comment to D25607: libalias: Use switch/case statements to compare IPv4 protocol type (TCP/UDP/ICMP).

This patch DOES reduce CPU usage, but not by 50%:

Fri, Jul 10, 5:09 PM · network
neel_neelc.org added a comment to D25607: libalias: Use switch/case statements to compare IPv4 protocol type (TCP/UDP/ICMP).

The test output was a speedtest.net on a system behind IPFW NAT, but I looked at my test firewall box and realized the patch didn't apply.

Fri, Jul 10, 4:35 PM · network
neel_neelc.org updated the diff for D25607: libalias: Use switch/case statements to compare IPv4 protocol type (TCP/UDP/ICMP).

Sure, fixed it.

Fri, Jul 10, 3:03 PM · network
neel_neelc.org updated the summary of D25607: libalias: Use switch/case statements to compare IPv4 protocol type (TCP/UDP/ICMP).
Fri, Jul 10, 2:17 AM · network
neel_neelc.org updated the summary of D25607: libalias: Use switch/case statements to compare IPv4 protocol type (TCP/UDP/ICMP).
Fri, Jul 10, 2:14 AM · network
neel_neelc.org updated the diff for D25607: libalias: Use switch/case statements to compare IPv4 protocol type (TCP/UDP/ICMP).

Let's also do alias_proxy.c.

Fri, Jul 10, 12:42 AM · network
neel_neelc.org requested review of D25607: libalias: Use switch/case statements to compare IPv4 protocol type (TCP/UDP/ICMP).
Fri, Jul 10, 12:13 AM · network

Thu, Jul 9

neel_neelc.org updated the diff for D25595: When modifying a route, only allow one of RTF_<BLACKHOLE,REJECT,GATEWAY> to be configured.

Good catch, reverting to my old diff.

Thu, Jul 9, 5:59 PM · network
neel_neelc.org updated the diff for D25595: When modifying a route, only allow one of RTF_<BLACKHOLE,REJECT,GATEWAY> to be configured.

Thanks for the suggestion.

Thu, Jul 9, 4:11 PM · network

Wed, Jul 8

neel_neelc.org requested review of D25595: When modifying a route, only allow one of RTF_<BLACKHOLE,REJECT,GATEWAY> to be configured.
Wed, Jul 8, 9:18 PM · network

Jul 7 2020

neel_neelc.org updated subscribers of D25546: Transition from rtrequest1_fib() to rib_action().
Jul 7 2020, 4:19 AM · network

Jul 6 2020

neel_neelc.org updated the diff for D23888: ipfw: Allow resolving of IPv6 DNS AAAA records in IPv6 table lookups.

Stop using memcpy here, instead use void pointers.

Jul 6 2020, 10:11 PM · network
neel_neelc.org added a comment to D23888: ipfw: Allow resolving of IPv6 DNS AAAA records in IPv6 table lookups.

Unbreak build on recent CURRENT by using memcpy.

Can you please explain, what the problem is?
Replacing a "struct assignment" by "memcpy" throws away several compile time checks while increasing the susceptibility to manual error.

Jul 6 2020, 9:53 PM · network
neel_neelc.org updated the diff for D23888: ipfw: Allow resolving of IPv6 DNS AAAA records in IPv6 table lookups.

Unbreak build on recent CURRENT by using memcpy.

Jul 6 2020, 3:51 AM · network

Jul 4 2020

neel_neelc.org added a project to D23461: netgraph: Add RFC 6598/Carrier Grade NAT support to ng_nat: network.
Jul 4 2020, 6:30 PM · network
neel_neelc.org added a project to D23356: natd: Add support for RFC 6598/Carrier Grade NAT subnets via libalias: network.
Jul 4 2020, 6:29 PM · network
neel_neelc.org added a comment to D23356: natd: Add support for RFC 6598/Carrier Grade NAT subnets via libalias.

Is it possible to do cgn without rfc1918? I think the changes should allow for that configuration.

Jul 4 2020, 5:55 PM · network
neel_neelc.org added a comment to D23461: netgraph: Add RFC 6598/Carrier Grade NAT support to ng_nat.

Here, added the testing section.

Jul 4 2020, 2:46 PM · network
neel_neelc.org updated the test plan for D23461: netgraph: Add RFC 6598/Carrier Grade NAT support to ng_nat.
Jul 4 2020, 2:46 PM · network

Jul 3 2020

neel_neelc.org abandoned D25553: nfs: Unbreak build post-r362903.
Jul 3 2020, 6:43 PM
neel_neelc.org updated the summary of D25553: nfs: Unbreak build post-r362903.
Jul 3 2020, 2:42 AM
neel_neelc.org requested review of D25553: nfs: Unbreak build post-r362903.
Jul 3 2020, 2:40 AM

Jul 2 2020

neel_neelc.org updated the diff for D25546: Transition from rtrequest1_fib() to rib_action().

Well, fixed the panics (which happened on BOOT on the first patch).

Jul 2 2020, 5:34 AM · network
neel_neelc.org added a comment to D25546: Transition from rtrequest1_fib() to rib_action().

This patch currently panics and needs revision

Jul 2 2020, 5:15 AM · network
neel_neelc.org requested review of D25546: Transition from rtrequest1_fib() to rib_action().
Jul 2 2020, 4:43 AM · network

Jun 29 2020

neel_neelc.org updated the diff for D25445: Complete the fib<4|6>_lookup_nh_<basic|ext> -> fib<4|6>_lookup() transition.

Made the changes.

Jun 29 2020, 10:32 AM · network

Jun 28 2020

neel_neelc.org added a comment to D25181: Introduce net.inet6.icmp6.reply_from_interface and net.inet6.icmp6.reply_src sysctls.

The Kyua log of my failing test is here: https://gist.github.com/neelchauhan/9e1ea12e0872f097294dc1f162b1a513

Jun 28 2020, 8:00 PM
neel_neelc.org added a comment to D25181: Introduce net.inet6.icmp6.reply_from_interface and net.inet6.icmp6.reply_src sysctls.

Unfortunately, I was unable to get test cases working. For some reason ICMP does not work in Kyua VNET jails. This is also why the other IPv6 forward/redirect tests fail as well.

Jun 28 2020, 3:21 AM

Jun 27 2020

neel_neelc.org updated the diff for D25181: Introduce net.inet6.icmp6.reply_from_interface and net.inet6.icmp6.reply_src sysctls.

This patch makes corrections to the man page and variable naming as mentioned by melifaro@ and 0mp@.

Jun 27 2020, 8:45 PM
neel_neelc.org updated the diff for D25181: Introduce net.inet6.icmp6.reply_from_interface and net.inet6.icmp6.reply_src sysctls.

Sorry for the delay.

Jun 27 2020, 5:29 PM
neel_neelc.org added a reviewer for D25481: Fix build on 13-CURRENT post-r362666 (nvpair.c to bsd_nvpair.c rename).: imp.
Jun 27 2020, 1:48 AM
neel_neelc.org requested review of D25481: Fix build on 13-CURRENT post-r362666 (nvpair.c to bsd_nvpair.c rename)..
Jun 27 2020, 1:37 AM

Jun 25 2020

neel_neelc.org added inline comments to D25445: Complete the fib<4|6>_lookup_nh_<basic|ext> -> fib<4|6>_lookup() transition.
Jun 25 2020, 10:35 PM · network
neel_neelc.org added inline comments to D25445: Complete the fib<4|6>_lookup_nh_<basic|ext> -> fib<4|6>_lookup() transition.
Jun 25 2020, 10:28 PM · network
neel_neelc.org updated the diff for D25445: Complete the fib<4|6>_lookup_nh_<basic|ext> -> fib<4|6>_lookup() transition.

Here's an updated diff.

Jun 25 2020, 10:27 PM · network
neel_neelc.org added inline comments to D25445: Complete the fib<4|6>_lookup_nh_<basic|ext> -> fib<4|6>_lookup() transition.
Jun 25 2020, 10:26 PM · network
neel_neelc.org updated the diff for D24011: ipfw: Support [w:x:y::z]:port (bracketed) IPv6 addresses in the fwd command.

Good catch on the tidbits, here's an revised patch.

Jun 25 2020, 4:12 PM · transport, network
neel_neelc.org updated the diff for D25445: Complete the fib<4|6>_lookup_nh_<basic|ext> -> fib<4|6>_lookup() transition.

Here, revised patch. Hope it is okay.

Jun 25 2020, 3:24 PM · network
neel_neelc.org added inline comments to D25445: Complete the fib<4|6>_lookup_nh_<basic|ext> -> fib<4|6>_lookup() transition.
Jun 25 2020, 3:23 PM · network
neel_neelc.org requested review of D25445: Complete the fib<4|6>_lookup_nh_<basic|ext> -> fib<4|6>_lookup() transition.
Jun 25 2020, 3:56 AM · network

Jun 24 2020

neel_neelc.org updated the diff for D24011: ipfw: Support [w:x:y::z]:port (bracketed) IPv6 addresses in the fwd command.

Made the corrections.

Jun 24 2020, 5:54 PM · transport, network
neel_neelc.org closed D25227: ipfw(4): make O_IPVER/ipversion match IPv4 or IPv6, not just IPv4 by itself.
Jun 24 2020, 4:58 PM · network
neel_neelc.org reclaimed D25227: ipfw(4): make O_IPVER/ipversion match IPv4 or IPv6, not just IPv4 by itself.
Jun 24 2020, 4:58 PM · network
neel_neelc.org abandoned D25075: netinet6: Don't calculate offset on ICMP6 NI query if the copied mbuf is null.
Jun 24 2020, 3:21 PM · network
neel_neelc.org reclaimed D24403: ipfw(8): In fill_ip6(), use a single statement for both "me" and "me6".
Jun 24 2020, 3:02 PM · transport, network
neel_neelc.org abandoned D21923: netinet: In multicast/broadcast udp(6)_input(), compare the IP details after we lock inp as well.
Jun 24 2020, 2:34 PM
neel_neelc.org abandoned D24403: ipfw(8): In fill_ip6(), use a single statement for both "me" and "me6".
Jun 24 2020, 2:26 PM · transport, network
neel_neelc.org abandoned D25227: ipfw(4): make O_IPVER/ipversion match IPv4 or IPv6, not just IPv4 by itself.
Jun 24 2020, 2:26 PM · network
neel_neelc.org abandoned D24192: ipfw: add dst-mac/src-mac shorthands to do filtering based on source/destination MAC.
Jun 24 2020, 2:23 PM · network
neel_neelc.org abandoned D22915: ipfw: Handle count > 1 in commit_rules().
Jun 24 2020, 2:23 PM · network

Jun 23 2020

neel_neelc.org added a project to D24011: ipfw: Support [w:x:y::z]:port (bracketed) IPv6 addresses in the fwd command: transport.
Jun 23 2020, 8:47 PM · transport, network
neel_neelc.org added a project to D24403: ipfw(8): In fill_ip6(), use a single statement for both "me" and "me6": transport.
Jun 23 2020, 8:46 PM · transport, network
neel_neelc.org updated the diff for D24937: Add tunable net.iflib.tx_update_freq to set transmit descriptor update frequency.

Done.

Jun 23 2020, 3:04 PM · network
neel_neelc.org added a comment to D25075: netinet6: Don't calculate offset on ICMP6 NI query if the copied mbuf is null.

Good catch.

Jun 23 2020, 2:29 PM · network
neel_neelc.org updated the diff for D25075: netinet6: Don't calculate offset on ICMP6 NI query if the copied mbuf is null.
Jun 23 2020, 2:29 PM · network
neel_neelc.org updated the diff for D24937: Add tunable net.iflib.tx_update_freq to set transmit descriptor update frequency.

I have a new patch making net.iflib.tx_update_freq a sysctl. I attempted to net.iflib.tx_update_freq=32 from 16 (without rebooting!) and it worked.

Jun 23 2020, 4:57 AM · network
neel_neelc.org requested review of D25075: netinet6: Don't calculate offset on ICMP6 NI query if the copied mbuf is null.
Jun 23 2020, 3:26 AM · network
neel_neelc.org requested review of D25076: netinet6: Remove erroneous periods in scope6.c.
Jun 23 2020, 3:25 AM · network
neel_neelc.org requested review of D25227: ipfw(4): make O_IPVER/ipversion match IPv4 or IPv6, not just IPv4 by itself.
Jun 23 2020, 3:22 AM · network
neel_neelc.org requested review of D25085: netinet6: In tcp_lro_rx_ipv6(), check for IPv6 flow ID..
Jun 23 2020, 3:21 AM · network
neel_neelc.org requested review of D24937: Add tunable net.iflib.tx_update_freq to set transmit descriptor update frequency.
Jun 23 2020, 3:21 AM · network
neel_neelc.org updated the diff for D24602: Remove erroneous spacing in SCTP_ABORT_ASSOCIATION case statement comment in send_reject6().

Thanks for the suggestions. I have made the requested changes here.

Jun 23 2020, 3:16 AM
neel_neelc.org requested review of D24602: Remove erroneous spacing in SCTP_ABORT_ASSOCIATION case statement comment in send_reject6().
Jun 23 2020, 3:16 AM

Jun 9 2020

neel_neelc.org updated the diff for D25181: Introduce net.inet6.icmp6.reply_from_interface and net.inet6.icmp6.reply_src sysctls.

Sure, added the man pages.

Jun 9 2020, 5:21 PM
neel_neelc.org updated the diff for D25181: Introduce net.inet6.icmp6.reply_from_interface and net.inet6.icmp6.reply_src sysctls.

Yeah, the scopes. In the else{} statement we get and check the scopes, but not in the new ones I made. I moved in6_splitscope() earlier so my new statements can use it also.

Jun 9 2020, 4:14 PM
neel_neelc.org updated the diff for D25181: Introduce net.inet6.icmp6.reply_from_interface and net.inet6.icmp6.reply_src sysctls.

Good catch! Try this patch with the added "hlim = in6_selecthlim(NULL, ifp);".

Jun 9 2020, 2:51 PM

Jun 7 2020

neel_neelc.org added a comment to D24403: ipfw(8): In fill_ip6(), use a single statement for both "me" and "me6".

I'm not a committer (I'm also not neel@), could someone please commit this?

Jun 7 2020, 11:54 PM · transport, network
neel_neelc.org added a comment to D24011: ipfw: Support [w:x:y::z]:port (bracketed) IPv6 addresses in the fwd command.

I'm not a committer (I'm also not neel@), could someone please commit this?

Jun 7 2020, 11:53 PM · transport, network
neel_neelc.org retitled D25181: Introduce net.inet6.icmp6.reply_from_interface and net.inet6.icmp6.reply_src sysctls from Introduce net.inet6.icmp6.reply_from_interface and \"net.inet.icmp.reply_src" sysctls to Introduce net.inet6.icmp6.reply_from_interface and net.inet6.icmp6.reply_src sysctls.
Jun 7 2020, 11:09 PM
neel_neelc.org requested review of D25181: Introduce net.inet6.icmp6.reply_from_interface and net.inet6.icmp6.reply_src sysctls.
Jun 7 2020, 11:06 PM

Jun 1 2020

neel_neelc.org added a comment to D24989: netinet: Generate a random RSS key on boot..

Should I sequence the key into "symmetrical RSS" where the first 32 bits == the next 32 bits, and all subsequent 16 bits chunks are equal?. Or is it something else?

Jun 1 2020, 6:00 PM · csprng, network
neel_neelc.org added a comment to D24989: netinet: Generate a random RSS key on boot..
In D24989#552576, @avg wrote:

I have a vague memory, maybe wrong, that commonly used fixed RSS keys were selected because they had some property (-ies).
So, maybe just being random is not good enough?
I think that hypothetical rss_isbadkey was mentioned for a reason?

Jun 1 2020, 4:29 PM · csprng, network
neel_neelc.org added a comment to D24989: netinet: Generate a random RSS key on boot..

I believe Linux just uses random keys:

Jun 1 2020, 4:27 PM · csprng, network

May 31 2020

neel_neelc.org added a comment to D24991: netinet: make ifa_ifwithaddr() and ifa_ifwithaddr_check() fib-aware.

Sorry for the delay, I filled in the testing section.

May 31 2020, 10:03 PM · network
neel_neelc.org updated the test plan for D24991: netinet: make ifa_ifwithaddr() and ifa_ifwithaddr_check() fib-aware.
May 31 2020, 10:03 PM · network
neel_neelc.org abandoned D25076: netinet6: Remove erroneous periods in scope6.c.
May 31 2020, 9:34 PM · network

May 30 2020

neel_neelc.org updated the diff for D24989: netinet: Generate a random RSS key on boot..

@cem thanks for the comments.

May 30 2020, 9:55 PM · csprng, network
neel_neelc.org added a comment to D24989: netinet: Generate a random RSS key on boot..

@kevans thanks for the suggestion, I added csprng to this thread.

May 30 2020, 8:53 PM · csprng, network
neel_neelc.org added a reviewer for D24989: netinet: Generate a random RSS key on boot.: csprng.
May 30 2020, 8:53 PM · csprng, network
neel_neelc.org added inline comments to D24989: netinet: Generate a random RSS key on boot..
May 30 2020, 8:04 PM · csprng, network