Page MenuHomeFreeBSD
Feed Advanced Search

Yesterday

jeff added a comment to D21548: (vm object 1) Replace busy checks and sleeps with acquires where it is trivial to do so..

One possible refinement that I should mention;

Sat, Sep 14, 6:45 PM

Fri, Sep 13

jeff added inline comments to D21629: Add support for multithreading the inactive queue pageout within a domain..
Fri, Sep 13, 12:06 AM

Thu, Sep 12

jeff updated the summary of D21629: Add support for multithreading the inactive queue pageout within a domain..
Thu, Sep 12, 11:27 PM
jeff created D21629: Add support for multithreading the inactive queue pageout within a domain..
Thu, Sep 12, 11:22 PM
jeff added inline comments to D21617: Improve support for refcount waiting.
Thu, Sep 12, 7:53 PM
jeff added inline comments to D21617: Improve support for refcount waiting.
Thu, Sep 12, 7:28 PM
jeff added inline comments to D21617: Improve support for refcount waiting.
Thu, Sep 12, 7:22 PM
jeff added a comment to D21617: Improve support for refcount waiting.

Can you describe the consumer visible effect you are trying to achieve? Is it just releasn?

Thu, Sep 12, 7:10 PM
jeff added inline comments to D21611: Introduce atomic per-page queue state operations..
Thu, Sep 12, 6:58 PM
jeff added inline comments to D21611: Introduce atomic per-page queue state operations..
Thu, Sep 12, 4:00 AM
jeff added inline comments to D21611: Introduce atomic per-page queue state operations..
Thu, Sep 12, 2:24 AM

Tue, Sep 10

jeff updated the summary of D21598: Use atomics for object reference count so that we can use the shared lock to protect it..
Tue, Sep 10, 8:40 PM
jeff created D21598: Use atomics for object reference count so that we can use the shared lock to protect it..
Tue, Sep 10, 8:34 PM
jeff created D21597: Drop the object lock where it is no longer needed..
Tue, Sep 10, 8:33 PM
jeff retitled D21596: (vm object 6) Convert pmap_is_modified, pmap_remove_write, and pmap_clear_modify to expecting busy to be held by the caller now that all callers hold it. from Convert pmap_is_modified, pmap_remove_write, and pmap_clear_modify to expecting busy to be held by the caller now that all callers hold it. to (vm object 6) Convert pmap_is_modified, pmap_remove_write, and pmap_clear_modify to expecting busy to be held by the caller now that all callers hold it..
Tue, Sep 10, 8:26 PM
jeff created D21596: (vm object 6) Convert pmap_is_modified, pmap_remove_write, and pmap_clear_modify to expecting busy to be held by the caller now that all callers hold it..
Tue, Sep 10, 8:24 PM
jeff retitled D21595: (vm object 5) Move PGA_NOSYNC to VPA_NOSYNC so that the object lock is not required. from Move PGA_NOSYNC to VPA_NOSYNC so that the object lock is not required. to (vm object 5) Move PGA_NOSYNC to VPA_NOSYNC so that the object lock is not required..
Tue, Sep 10, 8:23 PM
jeff created D21595: (vm object 5) Move PGA_NOSYNC to VPA_NOSYNC so that the object lock is not required..
Tue, Sep 10, 8:20 PM
jeff retitled D21594: (vm object 4) Wrap valid accesses in inlines. Add missing busy acquires to protect valid. from Wrap valid accesses in inlines. Add missing busy acquires to protect valid. to (vm object 4) Wrap valid accesses in inlines. Add missing busy acquires to protect valid..
Tue, Sep 10, 8:19 PM
jeff created D21594: (vm object 4) Wrap valid accesses in inlines. Add missing busy acquires to protect valid..
Tue, Sep 10, 8:11 PM
jeff retitled D21592: (vm object 3) Add a shared object busy synchronization mechanism that blocks new page busy acquires while held. from Add a shared object busy synchronization mechanism that blocks new page busy acquires while held. to (vm object 3) Add a shared object busy synchronization mechanism that blocks new page busy acquires while held..
Tue, Sep 10, 8:10 PM
jeff retitled D21549: (vm object 2) Don't release xbusy in vm_page_remove(), defer to vm_page_free_prep(). from Don't release xbusy in vm_page_remove(), defer to vm_page_free_prep(). to (vm object 2) Don't release xbusy in vm_page_remove(), defer to vm_page_free_prep()..
Tue, Sep 10, 7:59 PM
jeff retitled D21548: (vm object 1) Replace busy checks and sleeps with acquires where it is trivial to do so. from Replace busy checks and sleeps with acquires where it is trivial to do so. to (vm object 1) Replace busy checks and sleeps with acquires where it is trivial to do so..
Tue, Sep 10, 7:59 PM
jeff created D21592: (vm object 3) Add a shared object busy synchronization mechanism that blocks new page busy acquires while held..
Tue, Sep 10, 7:58 PM
jeff added inline comments to D21549: (vm object 2) Don't release xbusy in vm_page_remove(), defer to vm_page_free_prep()..
Tue, Sep 10, 7:13 PM
jeff committed rS352176: Replace redundant code with a few new vm_page_grab facilities:.
Replace redundant code with a few new vm_page_grab facilities:
Tue, Sep 10, 7:08 PM
jeff closed D21546: Eliminate redundant vm code with a few new convenience functions..
Tue, Sep 10, 7:08 PM
jeff committed rS352174: Use the sleepq lock rather than the page lock to protect against wakeup.
Use the sleepq lock rather than the page lock to protect against wakeup
Tue, Sep 10, 6:28 PM
jeff closed D21255: Remove the page lock dependency on busy sleeps by using sleepq to avoid races..
Tue, Sep 10, 6:28 PM
jeff added inline comments to D21549: (vm object 2) Don't release xbusy in vm_page_remove(), defer to vm_page_free_prep()..
Tue, Sep 10, 4:18 PM

Fri, Sep 6

jeff added inline comments to D21425: vfs: manage mnt_ref with atomics.
Fri, Sep 6, 6:53 PM
jeff abandoned D21331: Eliminate redundant code by introducing a vm_page_grab_valid().
Fri, Sep 6, 6:48 PM
jeff abandoned D21332: Augment vm_page_grab to support more cases that want to acquire busy locks..
Fri, Sep 6, 6:48 PM
jeff added inline comments to D21255: Remove the page lock dependency on busy sleeps by using sleepq to avoid races..
Fri, Sep 6, 2:44 PM
jeff retitled D21549: (vm object 2) Don't release xbusy in vm_page_remove(), defer to vm_page_free_prep(). from Don't release xbusy in vm_page_remove(), defer to vm_page_free_prep(). Some callers like vm_page_remove/replace want busy state to persist. to Don't release xbusy in vm_page_remove(), defer to vm_page_free_prep()..
Fri, Sep 6, 2:05 PM
jeff created D21549: (vm object 2) Don't release xbusy in vm_page_remove(), defer to vm_page_free_prep()..
Fri, Sep 6, 12:46 PM
jeff updated the summary of D21548: (vm object 1) Replace busy checks and sleeps with acquires where it is trivial to do so..
Fri, Sep 6, 12:45 PM
jeff created D21548: (vm object 1) Replace busy checks and sleeps with acquires where it is trivial to do so..
Fri, Sep 6, 12:43 PM
jeff retitled D21546: Eliminate redundant vm code with a few new convenience functions. from Eliminate redundant with a few new convenience functions. to Eliminate redundant vm code with a few new convenience functions..
Fri, Sep 6, 12:42 PM
jeff created D21546: Eliminate redundant vm code with a few new convenience functions..
Fri, Sep 6, 12:35 PM

Thu, Sep 5

jeff updated the diff for D21255: Remove the page lock dependency on busy sleeps by using sleepq to avoid races..

Resolve identity change issues

Thu, Sep 5, 6:31 PM
jeff added a comment to D17885: ULE scheduler: Interrupt thread natural binding to the core receiving the interrupt event is easily ignored.

This looks correct to me. Do you have any information from testing? How was this found?

Thu, Sep 5, 1:31 PM

Wed, Aug 21

D21357: Move OBJT_VNODE specific code from vm_object_terminate() to vnode_destroy_vobject(). is now accepted and ready to land.
Wed, Aug 21, 9:49 PM
jeff added a comment to D21357: Move OBJT_VNODE specific code from vm_object_terminate() to vnode_destroy_vobject()..

In general I like this but the double setting of OBJ_DEAD does make it harder to detect things like double frees.

Wed, Aug 21, 9:31 PM

Tue, Aug 20

jeff added inline comments to D21331: Eliminate redundant code by introducing a vm_page_grab_valid().
Tue, Aug 20, 8:33 PM
jeff added inline comments to D21332: Augment vm_page_grab to support more cases that want to acquire busy locks..
Tue, Aug 20, 8:23 PM
jeff added inline comments to D21332: Augment vm_page_grab to support more cases that want to acquire busy locks..
Tue, Aug 20, 8:16 PM
jeff added a comment to D21331: Eliminate redundant code by introducing a vm_page_grab_valid().

So it is ok to skip has_pages for vnode objects? This is a slight optimization that seems worthwhile to me.

Tue, Aug 20, 7:15 PM
jeff abandoned D21313: Eliminate redundant code by introducing a vm_page_grab_valid that will use the pager to bring in pages that are not valid..
Tue, Aug 20, 1:21 AM
jeff retitled D21332: Augment vm_page_grab to support more cases that want to acquire busy locks. from Augment vm_page_grab to support more cases that want to acquire busy locks. Add a new function, vm_page_busy_acquire(), to support others. to Augment vm_page_grab to support more cases that want to acquire busy locks..
Tue, Aug 20, 1:09 AM
jeff created D21332: Augment vm_page_grab to support more cases that want to acquire busy locks..
Tue, Aug 20, 1:04 AM
jeff retitled D21331: Eliminate redundant code by introducing a vm_page_grab_valid() from Eliminate redundant code by introducing a vm_page_grab_valid that will use the pager to bring in pages that are not valid. to Eliminate redundant code by introducing a vm_page_grab_valid().
Tue, Aug 20, 1:01 AM
jeff created D21331: Eliminate redundant code by introducing a vm_page_grab_valid().
Tue, Aug 20, 12:47 AM
jeff added a comment to D21255: Remove the page lock dependency on busy sleeps by using sleepq to avoid races..

Respond to review feedback. Eliminate the object locking changes for now.

Tue, Aug 20, 12:46 AM

Mon, Aug 19

jeff updated the summary of D21329: Bind to a CPU in the device's domain if UMA will allocate the memory there..
Mon, Aug 19, 11:41 PM
jeff created D21329: Bind to a CPU in the device's domain if UMA will allocate the memory there..
Mon, Aug 19, 11:39 PM
jeff committed rS351241: Use an atomic reference count for paging in progress so that callers do not.
Use an atomic reference count for paging in progress so that callers do not
Mon, Aug 19, 11:10 PM
jeff closed D21311: Use atomics for paging in progress..
Mon, Aug 19, 11:10 PM
jeff committed rS351235: Permit vm_pager_has_page() to run with a shared lock. Introduce.
Permit vm_pager_has_page() to run with a shared lock. Introduce
Mon, Aug 19, 10:25 PM
jeff closed D21310: Allow calls to vm_pager_haspages with the object read locked.
Mon, Aug 19, 10:25 PM
D16667: Extend uma_reclaim() to permit different reclamation targets. is now accepted and ready to land.
Mon, Aug 19, 9:30 PM
jeff added inline comments to D21311: Use atomics for paging in progress..
Mon, Aug 19, 5:56 PM
D20486: Change synchonization rules for page reference counting. is now accepted and ready to land.
Mon, Aug 19, 1:03 AM
jeff added inline comments to D20486: Change synchonization rules for page reference counting..
Mon, Aug 19, 12:00 AM

Sun, Aug 18

jeff committed rS351200: Allocate all per-cpu datastructures in domain correct memory..
Allocate all per-cpu datastructures in domain correct memory.
Sun, Aug 18, 11:44 PM
jeff closed D21242: Reallocate pcpu area on the correct domain..
Sun, Aug 18, 11:44 PM
jeff added inline comments to D20486: Change synchonization rules for page reference counting..
Sun, Aug 18, 11:40 PM
jeff committed rS351198: Allocate amd64's page array using pages and page directory pages from the.
Allocate amd64's page array using pages and page directory pages from the
Sun, Aug 18, 11:08 PM
jeff closed D21252: Allocate the vm_page_array on domain correct memory..
Sun, Aug 18, 11:08 PM
jeff committed rS351188: Add a blocking wait bit to refcount. This allows refs to be used as a simple.
Add a blocking wait bit to refcount. This allows refs to be used as a simple
Sun, Aug 18, 11:44 AM
jeff closed D21254: Add support for blocking waits to refcounts..
Sun, Aug 18, 11:44 AM
jeff created D21313: Eliminate redundant code by introducing a vm_page_grab_valid that will use the pager to bring in pages that are not valid..
Sun, Aug 18, 9:27 AM
jeff updated the summary of D21311: Use atomics for paging in progress..
Sun, Aug 18, 8:54 AM
jeff created D21311: Use atomics for paging in progress..
Sun, Aug 18, 8:50 AM
jeff retitled D21310: Allow calls to vm_pager_haspages with the object read locked from Allow read locked objects to call has_pages to Allow calls to vm_pager_haspages with the object read locked.
Sun, Aug 18, 8:46 AM
jeff created D21310: Allow calls to vm_pager_haspages with the object read locked.
Sun, Aug 18, 8:44 AM
jeff added a comment to D21242: Reallocate pcpu area on the correct domain..

If there is no strong objection I will commit this tomorrow.

Sun, Aug 18, 8:36 AM
jeff added inline comments to D21252: Allocate the vm_page_array on domain correct memory..
Sun, Aug 18, 8:35 AM
jeff updated the summary of D21252: Allocate the vm_page_array on domain correct memory..

Address review feedback. Move the page array between the direct map and kva.

Sun, Aug 18, 8:32 AM
jeff committed rS351183: Remove unnecessary debugging from r351181 that caused powerpc build to fail..
Remove unnecessary debugging from r351181 that caused powerpc build to fail.
Sun, Aug 18, 8:07 AM
jeff committed rS351182: vm_phys_avail_find is only used on NUMA kernels. Fix a build error..
vm_phys_avail_find is only used on NUMA kernels. Fix a build error.
Sun, Aug 18, 7:43 AM
jeff committed rS351181: Encapsulate phys_avail manipulation in a set of simple routines. Add a.
Encapsulate phys_avail manipulation in a set of simple routines. Add a
Sun, Aug 18, 7:06 AM
jeff closed D21251: Add phys_avail allocation routines..
Sun, Aug 18, 7:06 AM
jeff added inline comments to D21251: Add phys_avail allocation routines..
Sun, Aug 18, 6:40 AM

Aug 16 2019

jeff closed D21250: Move phys_avail and dump_avail into MI code..
Aug 16 2019, 4:56 PM
jeff committed rS351108: Move phys_avail definition into MI code. It is consumed in the MI layer and.
Move phys_avail definition into MI code. It is consumed in the MI layer and
Aug 16 2019, 12:45 AM

Aug 15 2019

jeff added a reviewer for D21242: Reallocate pcpu area on the correct domain.: mmacy.
Aug 15 2019, 7:29 PM

Aug 14 2019

jeff added a comment to D21255: Remove the page lock dependency on busy sleeps by using sleepq to avoid races..

Address review feedback. Clean up patch. Switch to fcmpset and rel semantics.

Aug 14 2019, 11:11 PM
jeff added inline comments to D21255: Remove the page lock dependency on busy sleeps by using sleepq to avoid races..
Aug 14 2019, 10:50 PM
jeff added a comment to D21254: Add support for blocking waits to refcounts..

Address review feedback

Aug 14 2019, 10:35 PM

Aug 13 2019

jeff added a comment to D21254: Add support for blocking waits to refcounts..

Address some of Markj's feedback. Move the last ref drop into a dedicated function to lessen text bloat.

Aug 13 2019, 9:56 PM
jeff added inline comments to D21255: Remove the page lock dependency on busy sleeps by using sleepq to avoid races..
Aug 13 2019, 8:48 PM
jeff added inline comments to D21255: Remove the page lock dependency on busy sleeps by using sleepq to avoid races..
Aug 13 2019, 8:43 PM
jeff updated the summary of D21255: Remove the page lock dependency on busy sleeps by using sleepq to avoid races..
Aug 13 2019, 8:16 PM
jeff updated the summary of D21254: Add support for blocking waits to refcounts..
Aug 13 2019, 8:10 PM
jeff created D21255: Remove the page lock dependency on busy sleeps by using sleepq to avoid races..
Aug 13 2019, 8:08 PM
jeff created D21254: Add support for blocking waits to refcounts..
Aug 13 2019, 8:02 PM
jeff added inline comments to D21250: Move phys_avail and dump_avail into MI code..
Aug 13 2019, 5:56 PM
jeff updated the summary of D21250: Move phys_avail and dump_avail into MI code..
Aug 13 2019, 5:53 PM
jeff updated the summary of D21252: Allocate the vm_page_array on domain correct memory..
Aug 13 2019, 5:47 PM