Page MenuHomeFreeBSD
Differential D23824

A pair of UMA optimizations to improve cache behavior.
ClosedPublic
Actions

Authored by jeff on Feb 24 2020, 11:26 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Sep 11, 12:49 AM
Unknown Object (File)
Mon, Sep 7, 1:45 PM
Unknown Object (File)
Sat, Sep 5, 11:03 AM
Unknown Object (File)
Sat, Sep 5, 3:50 AM
Unknown Object (File)
Fri, Sep 4, 12:23 PM
Unknown Object (File)
Fri, Sep 4, 6:42 AM
Unknown Object (File)
Fri, Sep 4, 1:52 AM
Unknown Object (File)
Thu, Sep 3, 10:09 PM
View All Files
Subscribers
imp

Details

Reviewers
rlibby
markj
Commits
rS358377: A pair of performance improvements.
Summary

This adds a missing swap to uma_zfree to protect lifo behavior. The alloc bucket is now always the most recent data. This was +8% on my test.

It changes the load balancing algorithm for ROUNDROBIN to more strongly prefer the current domain unless there is a severe imbalance. I don't recall the actual % gain but it was not insignificant.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jeff created this revision.Feb 24 2020, 11:26 PM
Harbormaster completed remote builds in B29584: Diff 68779.Feb 24 2020, 11:26 PM
jeff edited the summary of this revision. (Show Details)Feb 24 2020, 11:39 PM
jeff added reviewers: rlibby, markj.
jeff set the repository for this revision to rS FreeBSD src repository - subversion.
Herald added a subscriber: imp. · View Herald TranscriptFeb 24 2020, 11:39 PM
markj added inline comments.Feb 25 2020, 1:52 AM
sys/vm/uma_core.c
586 ↗(On Diff #68779)

Style: missing spaces around '*'.

587 ↗(On Diff #68779)

Suppose we have domains 0, 1 with 100 and 99 items, respectively, and pref == 0. Then prefitems is left equal to LONG_MAX and we will return domain 1, but it looks like the intent is to return 0 in this case.

jeff added inline comments.Feb 25 2020, 4:57 AM
sys/vm/uma_core.c
587 ↗(On Diff #68779)

Yeah I should just drop the else on if domain == pref.

rlibby accepted this revision.Feb 25 2020, 7:19 AM

Looks good after fixing Mark's comments.

sys/vm/uma_core.c
586 ↗(On Diff #68779)

You could just write this is if (prefitems <= least * 2).

This revision is now accepted and ready to land.Feb 25 2020, 7:19 AM
Closed by commit rS358377: A pair of performance improvements. (authored by jeff). · Explain WhyFeb 27 2020, 8:23 AM
This revision was automatically updated to reflect the committed changes.
jeff added a commit: rS358377: A pair of performance improvements..

Revision Contents
Changeset List

PathSize
head/
sys/
vm/
22 lines

Diff 68870

View Options

head/sys/vm/uma_core.c

Loading...