Page MenuHomeFreeBSD
Differential D23866

Add a lock free relookup for bogus page replacement.
ClosedPublic
Actions

Authored by jeff on Feb 27 2020, 10:38 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 12, 4:53 AM
Unknown Object (File)
Sat, Nov 1, 8:47 PM
Unknown Object (File)
Sat, Nov 1, 4:38 AM
Unknown Object (File)
Sun, Oct 26, 7:09 AM
Unknown Object (File)
Fri, Oct 24, 12:47 AM
Unknown Object (File)
Oct 14 2025, 8:02 PM
Unknown Object (File)
Oct 2 2025, 11:07 PM
Unknown Object (File)
Sep 26 2025, 5:33 AM
View All Files
Subscribers
imp

Details

Reviewers
markj
kib
alc
dougm
Commits
rS358451: Provide a lock free alternative to resolve bogus pages. This is not likely
Summary

I doubt that there is a measurable performance impact here but I think the resulting code is clearer and the scope of the object lock is further reduced.

We are very close to being able to eliminate explicit object locking from kern/*. It would be much easier to reason about the system if it was contained in vm/.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jeff created this revision.Feb 27 2020, 10:38 PM
Harbormaster completed remote builds in B29659: Diff 68924.Feb 27 2020, 10:38 PM
jeff edited the summary of this revision. (Show Details)Feb 27 2020, 10:47 PM
jeff added reviewers: markj, kib, alc, dougm.
jeff set the repository for this revision to rS FreeBSD src repository - subversion.
Herald added a subscriber: imp. · View Herald TranscriptFeb 27 2020, 10:47 PM
markj accepted this revision.Feb 28 2020, 3:35 PM
markj added inline comments.
sys/kern/vfs_bio.c
2881 ↗(On Diff #68924)

We don't seem to need the bogus flag variable anymore.

This revision is now accepted and ready to land.Feb 28 2020, 3:35 PM
jeff added inline comments.Feb 28 2020, 8:36 PM
sys/kern/vfs_bio.c
2881 ↗(On Diff #68924)

It is in the buf_mapped() check below.

kib accepted this revision.Feb 28 2020, 8:45 PM
Closed by commit rS358451: Provide a lock free alternative to resolve bogus pages. This is not likely (authored by jeff). · Explain WhyFeb 28 2020, 9:42 PM
This revision was automatically updated to reflect the committed changes.
jeff added a commit: rS358451: Provide a lock free alternative to resolve bogus pages. This is not likely.

Revision Contents
Changeset List

PathSize
head/
sys/
kern/
20 lines
19 lines
vm/
1 line
18 lines

Diff 68976

View Options

head/sys/kern/kern_sendfile.c

Loading...
View Options

head/sys/kern/vfs_bio.c

Loading...
View Options

head/sys/vm/vm_page.h

Loading...
View Options

head/sys/vm/vm_page.c

Loading...