Page MenuHomeFreeBSD

Make grab_valid more consistent with other grab functions by requiring ZERO.
AcceptedPublic

Authored by jeff on Mar 11 2020, 8:27 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Oct 31, 7:34 PM
Unknown Object (File)
Tue, Oct 14, 7:23 PM
Unknown Object (File)
Sep 12 2025, 5:19 PM
Unknown Object (File)
Sep 12 2025, 2:29 PM
Unknown Object (File)
Sep 12 2025, 7:47 AM
Unknown Object (File)
Sep 10 2025, 2:38 PM
Unknown Object (File)
Sep 5 2025, 5:54 PM
Unknown Object (File)
Sep 5 2025, 9:28 AM
Subscribers

Details

Reviewers
alc
dougm
kib
markj
Summary

After this change vm_page_grab_valid() requires callers to specify ZERO if they want to fill in sparse files/objects. I audited all consumers and a couple wanted it and a couple did not. This makes valid much more consistent with the others although there are still quirks around NOWAIT/WAITFAIL that could be eliminated if necessary.

Test Plan

stress2

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 29884
Build 27704: arc lint + arc unit

Event Timeline

jeff edited the test plan for this revision. (Show Details)
jeff added reviewers: alc, dougm, kib, markj.
jeff set the repository for this revision to rS FreeBSD src repository - subversion.

I think that the behavior of VM_ALLOC_ZERO/has_page should be documented in the comment.

This revision is now accepted and ready to land.Mar 12 2020, 10:55 PM