Page MenuHomeFreeBSD

Make grab_valid more consistent with other grab functions by requiring ZERO.
AcceptedPublic

Authored by jeff on Mar 11 2020, 8:27 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sep 22 2024, 2:34 AM
Unknown Object (File)
Sep 12 2024, 6:38 PM
Unknown Object (File)
Sep 8 2024, 6:54 PM
Unknown Object (File)
Sep 7 2024, 11:25 AM
Unknown Object (File)
Aug 28 2024, 7:19 AM
Unknown Object (File)
Aug 4 2024, 9:25 PM
Unknown Object (File)
Jul 12 2024, 1:22 AM
Unknown Object (File)
Jul 9 2024, 6:10 PM
Subscribers

Details

Reviewers
alc
dougm
kib
markj
Summary

After this change vm_page_grab_valid() requires callers to specify ZERO if they want to fill in sparse files/objects. I audited all consumers and a couple wanted it and a couple did not. This makes valid much more consistent with the others although there are still quirks around NOWAIT/WAITFAIL that could be eliminated if necessary.

Test Plan

stress2

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 29884
Build 27704: arc lint + arc unit

Event Timeline

jeff edited the test plan for this revision. (Show Details)
jeff added reviewers: alc, dougm, kib, markj.
jeff set the repository for this revision to rS FreeBSD src repository - subversion.

I think that the behavior of VM_ALLOC_ZERO/has_page should be documented in the comment.

This revision is now accepted and ready to land.Mar 12 2020, 10:55 PM