Page MenuHomeFreeBSD

Make grab_valid more consistent with other grab functions by requiring ZERO.
AcceptedPublic

Authored by jeff on Mar 11 2020, 8:27 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, May 5, 12:59 AM
Unknown Object (File)
Dec 20 2023, 6:34 AM
Unknown Object (File)
Aug 26 2023, 1:11 PM
Unknown Object (File)
Jun 21 2023, 2:03 PM
Unknown Object (File)
May 11 2023, 5:54 AM
Unknown Object (File)
May 2 2023, 8:54 AM
Unknown Object (File)
Mar 4 2023, 10:56 AM
Unknown Object (File)
Mar 2 2023, 4:28 PM
Subscribers

Details

Reviewers
alc
dougm
kib
markj
Summary

After this change vm_page_grab_valid() requires callers to specify ZERO if they want to fill in sparse files/objects. I audited all consumers and a couple wanted it and a couple did not. This makes valid much more consistent with the others although there are still quirks around NOWAIT/WAITFAIL that could be eliminated if necessary.

Test Plan

stress2

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 29884
Build 27704: arc lint + arc unit

Event Timeline

jeff edited the test plan for this revision. (Show Details)
jeff added reviewers: alc, dougm, kib, markj.
jeff set the repository for this revision to rS FreeBSD src repository - subversion.

I think that the behavior of VM_ALLOC_ZERO/has_page should be documented in the comment.

This revision is now accepted and ready to land.Mar 12 2020, 10:55 PM