I feel like this change also needs to incorporate https://reviews.freebsd.org/D30176 somehow - maybe check the platform first, then remove the tests that depend on absolute paths?
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
May 8 2021
A thought: could we also mention that we need to install some dependencies and they may have different package names?
May 7 2021
IMO we could indeed recommend textproc/docproj. If we are going with this minimal approach, maybe try all checks and pop up the recommendations all at once, to avoid people having to run it multiple times to satisfy all dependencies? (and we can even recommend both)
May 6 2021
In D30145#676725, @fel1x.mintchoco.development_gmail.com wrote:change2.diff65 KBDownload
Thank you for your advice. Here is a new full diff file. I corrected :s and deleteed things that are not ready yet(VMware Workstation, Hyper-V).
Hi! Before diving into the review, two quick suggestions:
- It is usually better to submit patches that are generated by diff -U999999 to give better contexts to reviewers.
- Populating the "Test Plan" section of the reviews is recommended (e.g. doc builds fine, images displayed correctly, etc).
May 5 2021
May 4 2021
May 3 2021
May 2 2021
Apr 29 2021
Looks good to me!
Apr 28 2021
Apr 27 2021
Apr 26 2021
Apr 18 2021
Apr 17 2021
In D29717#667346, @dbaio wrote:what about adding this note and wait for 3 or 6 months? If we don't have any progress we can remove that. And I can add this reminder for myself.
Mar 28 2021
Mar 26 2021
Also closing the related PR. https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=252116
Mar 23 2021
I don't believe so - I thought we are waiting for @timur since I am not a ports committer, but in this case, I can commit it with his approval on this review.
Mar 16 2021
Mar 13 2021
Mar 10 2021
Committed as:
Mar 9 2021
LGTM, just threw it into Poudriere and waiting for @lwhsu 's approval.
Mar 8 2021
Mar 5 2021
Feb 28 2021
Feb 27 2021
Feb 26 2021
Feb 25 2021
Feb 22 2021
Feb 20 2021
Feb 19 2021
LGTM on the doc side, thanks!
Just a quick note that the submitter is not a committer, so someone needs to commit this one ;)
Feb 15 2021
Closed by https://reviews.freebsd.org/D27774.
Needs rebase to the new doc infra.
Feb 13 2021
Feb 11 2021
LGTM on the doc side, please update .Dd when committing, thanks ;)