Details

Reviewers

philip
lwhsu
debdrup
ygy

Group Reviewers

docs

Commits

R9:aa0d0c142274: Alternative formatting on freebsd/developer/* blocks

Diff Detail

Repository

R9 FreeBSD doc repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

khng requested review of this revision.Mar 16 2021, 11:43 AM

khng created this revision.

Harbormaster completed remote builds in B37858: Diff 85829.Mar 16 2021, 11:43 AM

Good catch!

Approved by: philip (mentor)

This revision is now accepted and ready to land.Mar 16 2021, 11:49 AM

lwhsu accepted this revision.Mar 16 2021, 11:58 AM

lwhsu added a reviewer: docs.

Once you've tested that it looks good, with make -C /usr/doc/documentation (run|build), you're welcome to go ahead and commit this. :)

khng retitled this revision from Restore _index.adoc formatting to the intended one to Use double underscore than breaking up freebsd/developer.Mar 16 2021, 4:01 PM

Revised the old rendering

This revision now requires review to proceed.Mar 16 2021, 4:02 PM

Harbormaster completed remote builds in B37865: Diff 85841.Mar 16 2021, 4:02 PM

khng retitled this revision from Use double underscore than breaking up freebsd/developer to Simplify formatting and use underscores in freebsd/developer blocks.Mar 16 2021, 4:34 PM

Use underscore

Harbormaster completed remote builds in B37866: Diff 85842.Mar 16 2021, 4:35 PM

ygy accepted this revision.Mar 16 2021, 5:04 PM

This revision is now accepted and ready to land.Mar 16 2021, 5:04 PM

I would also suggest adding a link to https://wiki.freebsd.org/IRC/Cloaks, as that explains the requirements, et cetera.

documentation/content/en/articles/committers-guide/_index.adoc
3252–3253	This would align it with how manual pages denote mandatory fields. I believe it's also used elsewhere in the FreeBSD documentation (although examples escape me right now).

khng retitled this revision from Simplify formatting and use underscores in freebsd/developer blocks to Alternative formatting on freebsd/developer/* blocks.Mar 16 2021, 6:05 PM

Alternative formatting on freebsd/developer/* blocks

Suggested by debdrup

This revision now requires review to proceed.Mar 16 2021, 6:06 PM

Harbormaster completed remote builds in B37870: Diff 85848.Mar 16 2021, 6:06 PM

khng marked an inline comment as done.Mar 16 2021, 6:06 PM

philip accepted this revision.Mar 17 2021, 1:13 AM

This revision is now accepted and ready to land.Mar 17 2021, 1:13 AM

Closed by commit R9:aa0d0c142274: Alternative formatting on freebsd/developer/* blocks (authored by khng). · Explain WhyMar 17 2021, 2:48 AM

This revision was automatically updated to reflect the committed changes.

khng added a commit: R9:aa0d0c142274: Alternative formatting on freebsd/developer/* blocks.