Page MenuHomeFreeBSD
Feed Advanced Search

Jul 11 2023

rcm added a comment to D40972: libbe: recursively promote deep BE datasets.

For future diffs, please include full context (-U999999) or use arc

Jul 11 2023, 6:38 PM
rcm added a reviewer for D40972: libbe: recursively promote deep BE datasets: rew.
Jul 11 2023, 11:35 AM
rcm requested review of D40972: libbe: recursively promote deep BE datasets.
Jul 11 2023, 11:34 AM

Jul 10 2023

rcm attached a referenced file: F64180042: termbin.com_sf9j.txt.
Jul 10 2023, 8:35 PM
rcm requested changes to D40903: libbe: promote activated BEs all the way.

This does not completely align with beadm behavior.

Jul 10 2023, 8:32 PM

Jul 7 2023

rcm added a member for Loader: rcm.
Jul 7 2023, 11:54 AM
rcm accepted D40903: libbe: promote activated BEs all the way.

This looks good to me, it fixes the case I was hitting.

Jul 7 2023, 11:52 AM

Jun 30 2023

rcm updated the diff for D40816: bsdinstall: protect disk label and zfsboot on Auto ZFS+MBR.

Drop the magic number and make it configurable

Jun 30 2023, 8:53 PM
rcm requested review of D40816: bsdinstall: protect disk label and zfsboot on Auto ZFS+MBR.
Jun 30 2023, 7:01 PM

Jun 12 2023

rcm added a comment to D40442: wpa_supplicant: Enable receiving priority tagged (VID 0) frames.

For the print alone it's beneficial to read the VLAN ID and show it. The way it is now it just pushes the maintenance cost to a future point/individual if the PCAP implementation doesn't do what is assumed here (and not even correctly documented as a comment).

Jun 12 2023, 7:12 PM · pfsense
rcm updated the summary of D40442: wpa_supplicant: Enable receiving priority tagged (VID 0) frames.
Jun 12 2023, 2:29 PM · pfsense
rcm updated the summary of D40442: wpa_supplicant: Enable receiving priority tagged (VID 0) frames.
Jun 12 2023, 2:29 PM · pfsense
rcm added inline comments to D40442: wpa_supplicant: Enable receiving priority tagged (VID 0) frames.
Jun 12 2023, 2:29 PM · pfsense

Jun 9 2023

rcm added a comment to D40442: wpa_supplicant: Enable receiving priority tagged (VID 0) frames.

I managed to get subscribed to the hostap mailing list. I also brought along another patch from FreeBSD so the l2 receive code should now be consistent between the two trees.

Jun 9 2023, 4:33 PM · pfsense

Jun 8 2023

rcm updated the diff for D40442: wpa_supplicant: Enable receiving priority tagged (VID 0) frames.

There was a regression in the latest diff. That has been fixed now.

Jun 8 2023, 7:13 PM · pfsense
rcm added inline comments to D40317: carp: add a 'SUPPRESS' state.
Jun 8 2023, 1:37 PM
rcm added a comment to D40442: wpa_supplicant: Enable receiving priority tagged (VID 0) frames.
In D40442#921284, @cy wrote:

Can you also please send this to our upstream, hostap@lists.infradead.org. I prefer not having our source diverge from upstream too much.

Other than that, looks good. I'll do some regression testing here.

Jun 8 2023, 1:23 PM · pfsense
rcm updated the diff for D40442: wpa_supplicant: Enable receiving priority tagged (VID 0) frames.

Not sure why the last diff did not apply. I recreated it. Hopefully this one works.

Jun 8 2023, 2:54 AM · pfsense

Jun 7 2023

rcm added a member for vbox: rcm.
Jun 7 2023, 8:22 PM
rcm added a member for pfsense: rcm.
Jun 7 2023, 8:20 PM
rcm retitled D40442: wpa_supplicant: Enable receiving priority tagged (VID 0) frames from wip: wpa_supplicant: Enable receiving priority tagged (VID 0) frames to wpa_supplicant: Enable receiving priority tagged (VID 0) frames.
Jun 7 2023, 4:38 PM · pfsense
rcm updated the diff for D40442: wpa_supplicant: Enable receiving priority tagged (VID 0) frames.

This revision narrows the scope of change to only focus on FreeBSD related L2 packet handling in wpa_supplicant. The previous revision updated all occurrences of the filter program, however failed to account for packet and length offsets when handling encapsulated frames. Someone else can pick up the torch and provide patches for other platforms upstream as-needed.

Jun 7 2023, 4:31 PM · pfsense
rcm retitled D40442: wpa_supplicant: Enable receiving priority tagged (VID 0) frames from wpa_supplicant: Enable receiving priority tagged (VID 0) frames to wip: wpa_supplicant: Enable receiving priority tagged (VID 0) frames.
Jun 7 2023, 1:31 PM · pfsense

Jun 6 2023

rcm requested review of D40442: wpa_supplicant: Enable receiving priority tagged (VID 0) frames.
Jun 6 2023, 7:29 PM · pfsense