address dteske's feedback: localize "module" var

address some of dteske's feedback

per dteske, it's fine to just use docker_dir

include dteske's changes to the rc script and wrap them im prestart

s/post-install/do-install/ - it makes more sense this way

list myself as maintainer per dteske

The /var/db and /var/log stuff is OK to have hardcoded, but anything under /usr/local (like ETCDIR) is not.

You have my approval to commit once you get approval from portmgr.

Ahh, you're right!

Cool, thanks! The backports.* stuff is backports of Python 3 features to Python 2, so these should not be necessary for Python 3 at all.

Yep. I tried it with security/py-backports.ssl_match_hostname and... it doesn't work.
I'll switch the test port to that one once I figure out a correct fix.

I would like some help with filtering files out of generated plist. I can't figure out how to do this. I tested conversion of a port that actually needs this and it *is* necessary.

o use compileall with -d flag
o add a sample consumer to the patch

You file a PR flagged exp-run with a patch attached to it and explaining what it's supposed to.

This looks pretty awesome to me!

I think this is clean enough to move forward. Can you request an exp-run please?

I tested this. Looks good! Please commit when ready.

Is it better to just call it MMCCAM instead of GENERIC-MMCCAM?

Get Yuri's approval (just send him an email or something) and you can commit the GH_ACCOUNT change.

Looks great, approved!

bundle is not able to always check the gemfile out of various/complex reasons
often there are gemfiles in a project which are not executed (QA for example) and which could not satisfied because the needed ports are missing.

Looks like these just got updated to 8u144.

Looks good!

This is done, but I accidentally put the wrong revision in commit message.

Umm, sorry, commit message snafu

These two could have different solutions:

• only test when USE_RUBY = yes

You can export something from bsd.ruby.mk and check for that. This is an obvious one, but you can pick something else if you think it's better.

• only test if bundle exists

You can have some sort of a simpler fallback or just limit the scope to ports using bundle.

What do you think of the current approach?

Approved!

Looks good!

Approved!

The pre/post stuff is unnecessary.

Yeah, that's right. Just adding PORTNAME to QA_ENV works though.

qa.sh runs in STAGEDIR

just export PORTNAME instead of "make -VPORTNAME -C../.." dance

address mat's feedback:

fix finding .gemspec for PKGBASE with numeric suffix

Can we regenerate the patches with next port update instead?

Add a note that you are also unsilencing an install command (which is good).
I don't think this qualifies for any blanket approvals and even then,
you would typically list either a person(s) or a blanket approval, not both.

Yeah, unfortunately, GH_TUPLE + USES=go is a mess right now.
Maybe some motivated person can come along and add an extract dir to GH_TUPLE regex....

Looks good!

Looks good now!

Can you test it on a box where
o teamspeak uses sqlite
o rc.conf has mysql_enable="NO"
o mysql server is installed

Is this conditional? What if sqlite is used?

Approved!

Approved!

Approved!

Approved!

Mention all affected ports in the commit message.
Otherwise, this looks OK!

Looks good!

whoops, included too much

address mat's feedback:

address mat's feedback:

Looks good!

Looks good!

Looks great!

Looks good to me!

Approved.

Approved!

address sunpoet's feedback: