Page MenuHomeFreeBSD

cad/ngspice_rework: Add option to build as shared library
ClosedPublic

Authored by ultima on Jul 25 2017, 1:04 PM.

Details

Summary
  • Enabled CIDER
  • Added New option, SHLIB, only X11 or SHLIB can be selected, X11 is the default
  • Moved Uses to start Uses section block
  • Sorted option section to better comply with handbook (13.1.8)[1]

[1] https://www.freebsd.org/doc/en/books/porters-handbook/porting-samplem.html#porting-samplem-order

PR\: 216800
Sumitted by\: Kevin Zheng <kevinz5000@gmail.com> (maintainer)
Reviewed by\: lifanov (mentor), matthew (mentor)
Approved by\: lifanov (mentor), matthew (mentor)
Differential Revision\: https://reviews.freebsd.org/DXXXXX

Test Plan

portlint:
WARN: Makefile: for new port, make $FreeBSD$ tag in comment section empty, to make SVN happy.
WARN: Makefile: new ports should not set PORTREVISION.
0 fatal errors and 2 warnings found.

poudriere:
103i386
103amd64
110i386
110amd64
12i386
12amd64

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ultima created this revision.Jul 25 2017, 1:04 PM
ultima updated this revision to Diff 31171.Jul 25 2017, 1:06 PM

Remove the X11 define from testing

lifanov accepted this revision.Jul 26 2017, 2:20 PM

Looks good!

This revision is now accepted and ready to land.Jul 26 2017, 2:20 PM
This revision was automatically updated to reflect the committed changes.