In D44198#1008346, @bapt wrote:

pkg -c chroot clean -y -a

Will do the same without the need of mounting /dev other bonus, no emulator is needed

I thought I said Ship It. :D

Although the patch looks fine to me the planned commit message is not.

In D44179#1008121, @uzsolt wrote:

So how about:

${REINPLACE_CMD} -e 's| .(PREFIX)| $$(DESTDIR)$$(PREFIX)|g' ${WRKSRC}/Makefile

It isn't right because the manual page's directory will be PREFIX/man/man1 instead of PREFIX/share/man/man1 (the share subdirectory missed).
What do you think about 's|$$(PREFIX)|$$(DESTDIR)$$(PREFIX)| ; s|man/man1|share/man/man1|' ?

Yeap you are correct, I missed the man share/man thing. For the last couple of days I have worked too much on the share/man that they look the same to me. :D

My knowledge on the x11 stuff is a bit rusty so I will refrain from reviewing this.

As mentioned earlier poudriere's lib detection method is not too robust and might not be the correct way to follow. So do not blindly remove those and retest like you have done here. curl should stay if it throws an error while absent.

@diizzy This is not plain yaml I think and not too much ports should be dependent upon this.

This is a bit awkward that you are running sed twice on the same file. These should be really avoided because this is what happens in the background:

Reiterating the informations about patching:

• Whenever updating a software try to refresh the patches. That is make patch and make makepatch.
• If you have any post-patch target on the same files make sure to disable/uncomment the post-patch target otherwise you will have improper patches.
• makepatch format is better for builders. Patching is highly CPU intensive so even if the diffs/hunks are skewed by 1 line it creates extra CPU cycles in the builders.
• If the patch is an upstream commit utilize the PATCH_SITES and PATCHFILES compared to local patches.
• Although you will see me personally utilizing lots of REINPLACE_CMD this is not intended except for smaller cases which are really clear with the search and replace like what it is doing. For example when you are rewriting /usr with LOCALBASE, or replacing CC feel free to utilize REINPLACE_CMD.

As it warns you are warranted to run make makepatch. :D