Page MenuHomeFreeBSD
Differential D33305

loader: framebuffer should only be written into
ClosedPublic
Actions

Authored by tsoome on Dec 6 2021, 5:27 PM.
Tags
None
Referenced Files
F106954014: D33305.id99848.diff
Wed, Jan 8, 12:35 AM
F106954008: D33305.id.diff
Wed, Jan 8, 12:35 AM
F106953996: D33305.id99576.diff
Wed, Jan 8, 12:34 AM
F106953027: D33305.diff
Wed, Jan 8, 12:15 AM
Unknown Object (File)
Mon, Dec 9, 6:51 PM
Unknown Object (File)
Dec 4 2024, 1:13 AM
Unknown Object (File)
Dec 2 2024, 3:13 AM
Unknown Object (File)
Nov 30 2024, 5:13 AM
View All 52 Files
Subscribers
bcran
dab
imp
val_packett.cool

Details

Reviewers
manu
Commits
rG04a0bd52d6c2: loader: framebuffer should only be written into
rG6102f43cf060: loader: framebuffer should only be written into
Summary

Reading from Write Combining memory can be very-very slow. Try to use
shadow buffer to avoid such reads.

Test Plan

Both UEFI and VBE frame buffers appear to behave as expected, no
visual defects. My ability for performance tests is rather limited,
unfortunately.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tsoome created this revision.Dec 6 2021, 5:27 PM
Herald added subscribers: dab, bcran, imp. · View Herald TranscriptDec 6 2021, 5:27 PM
tsoome requested review of this revision.Dec 6 2021, 5:27 PM
Harbormaster completed remote builds in B43196: Diff 99576.Dec 6 2021, 5:27 PM
val_packett.cool added a subscriber: val_packett.cool.Dec 6 2021, 8:39 PM

Excellent, this very significantly improves the loader's performance on my desktop (AMD Radeon RX Vega GPU)

This revision was not accepted when it landed; it landed in state Needs Review.Dec 11 2021, 11:27 AM
Closed by commit rG6102f43cf060: loader: framebuffer should only be written into (authored by tsoome). · Explain Why
This revision was automatically updated to reflect the committed changes.
tsoome added a commit: rG6102f43cf060: loader: framebuffer should only be written into.
tsoome added a commit: rG04a0bd52d6c2: loader: framebuffer should only be written into.Jan 10 2022, 12:26 PM
Herald added a reviewer: manu. · View Herald TranscriptJan 10 2022, 12:26 PM

Revision Contents
Changeset List

PathSize
stand/
common/
3 lines
152 lines
efi/
loader/
3 lines
i386/
libi386/
4 lines

Diff 99848

View Options

stand/common/gfx_fb.h

Loading...
View Options

stand/common/gfx_fb.c

Loading...
View Options

stand/efi/loader/framebuffer.c

Loading...
View Options

stand/i386/libi386/vbe.c

Loading...