pfsync: locking fixes
ClosedPublic
Actions

Authored by kp on Dec 3 2021, 9:49 AM.

Details

Reviewers

Group Reviewers

network
pfsense

Commits

rG7164b77ce2f3: pfsync: locking fixes
rG87246654e350: pfsync: locking fixes
rG41c4f1987243: pfsync: locking fixes

Summary

Ensure we unlock the pfsync lock in pfsync_defer()
We must hold the bucket lock when calling pfsync_push()
The pfsync_defer_tmo() callout locks the bucket lock, not the pfsync lock

MFC after: 1 week
Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kp created this revision.Dec 3 2021, 9:49 AM

Herald added subscribers: glebius, melifaro, farrokhi, imp. · View Herald TranscriptDec 3 2021, 9:49 AM

kp requested review of this revision.Dec 3 2021, 9:49 AM

Harbormaster completed remote builds in B43118: Diff 99390.Dec 3 2021, 9:49 AM

kp added a parent revision: D33242: pfsync: fix defer timeout.Dec 3 2021, 9:49 AM

kp added a child revision: D33244: pfsync: fix incorrect enabling of defer mode.

glebius accepted this revision.Dec 3 2021, 4:52 PM

This revision is now accepted and ready to land.Dec 3 2021, 4:52 PM

Closed by commit rG41c4f1987243: pfsync: locking fixes (authored by kp). · Explain WhyDec 6 2021, 12:26 PM

This revision was automatically updated to reflect the committed changes.

kp added a commit: rG41c4f1987243: pfsync: locking fixes.

kp added a commit: rG87246654e350: pfsync: locking fixes.Dec 13 2021, 1:51 PM

kp added a commit: rG7164b77ce2f3: pfsync: locking fixes.

Revision Contents
Changeset List

Path

Size

sys/

netpfil/

pf/

if_pfsync.c

10 lines

Diff 99546

View Options

sys/netpfil/pf/if_pfsync.c

pfsync: locking fixesClosedPublicActions