Add an option of -h --human to output human readable size unit instead of the fixed unit (MB).
Signed-off-by: Wanpeng Qian <wanpengqian@gmail.com>
Details
Details
- Reviewers
imp chuck - Group Reviewers
manpages - Commits
- rG9c1bec9c21a2: nvmecontrol: improve namespace size unit of devlist command output
For vary disk sizes, check the command output.
Diff Detail
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 42978 Build 39866: arc lint + arc unit
Event Timeline
| sbin/nvmecontrol/devlist.c | ||
|---|---|---|
| 140 | When j == strlen(unit), which %c is \0, printf will not output the char. I search the web, people say it will teminate the output here. but the test seems OK. | |
| sbin/nvmecontrol/nvmecontrol.8 | ||
|---|---|---|
| 219 | Maybe also s/shows in/uses/ for consistency with the previous sentence, but that's a matter of taste. The typo itself is the important thing. | |
Comment Actions
Looks good to me.
For me to commit it, I need either a 'Signed-off-by:' line or email imp@bsdimp.com a git-format-patch bundle with your preferred author name.
| sbin/nvmecontrol/devlist.c | ||
|---|---|---|
| 103 | why 7? | |
Comment Actions
I have added the 'Signed-off-by:' line.
| sbin/nvmecontrol/devlist.c | ||
|---|---|---|
| 103 | The /bin/df uses 6, since we have an extra suffix "B", I use 7 to match the result of df. The output contains 4 digits. it is readable yet enough to get more information. | |
Comment Actions
I'll use an author name of 'Wanpeng Qian <wanpengqian@gmail.com>' to commit this.
Please confirm.