Differential D4067

Implement new make_dev_args() API
AbandonedPublic
Actions

Authored by • hselasky on Nov 2 2015, 3:03 PM.

Project Tags

None

Referenced Files

None

Subscribers

imp

Details

Reviewers

kib
jhb
glebius
rwatson

Summary

To solve races setting character device variables, a new character device API is adviced.

Example:

struct cdev *pcdev;
int retval;

retval = MAKE_DEV_ARGS(&pcdev, (.si_uid = 0, .si_gid = 0,.si_mode = 0777), "testdev");

#define MAKE_DEV_ARGS(ppdev,args,...) \

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

• hselasky updated this revision to Diff 9883.Nov 2 2015, 3:03 PM

• hselasky retitled this revision from to Implement new make_dev_args() API.

• hselasky updated this object.

• hselasky edited the test plan for this revision. (Show Details)

• hselasky added reviewers: kib, rwatson, glebius, jhb.

• hselasky set the repository for this revision to rS FreeBSD src repository - subversion.

Herald added a subscriber: imp. · View Herald TranscriptNov 2 2015, 3:03 PM

Compile fix.

Update code style.

Ping

I am sorry, apparently I missed this review when you posted it.

I did prototyped very similar patch last time we talked. Differences are in the handling of the make_dev_args structure grow, I made it completely automatic without manual checks for the version. Also, I think my handling of (obsoleted) unit numbers is, in some sense, better.

I will put my variation onto review in a second.

UPDATE: D4746

kib mentioned this in D4746: make_dev_s().Dec 31 2015, 3:47 PM

Superceeded by D4746 .