Page MenuHomeFreeBSD
Differential D4067

Implement new make_dev_args() API
AbandonedPublic
Actions

Authored by • hselasky on Nov 2 2015, 3:03 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 16, 9:26 AM
Unknown Object (File)
Mon, Apr 14, 6:14 AM
Unknown Object (File)
Mon, Apr 14, 5:52 AM
Unknown Object (File)
Mon, Apr 14, 5:30 AM
Unknown Object (File)
Mon, Apr 14, 5:23 AM
Unknown Object (File)
Mon, Apr 14, 3:13 AM
Unknown Object (File)
Sat, Apr 12, 11:20 PM
Unknown Object (File)
Jan 18 2025, 8:08 PM
View All 74 Files
Subscribers
imp

Details

Reviewers
kib
jhb
glebius
rwatson
Summary

To solve races setting character device variables, a new character device API is adviced.

Example:

struct cdev *pcdev;
int retval;

retval = MAKE_DEV_ARGS(&pcdev, (.si_uid = 0, .si_gid = 0,.si_mode = 0777), "testdev");

#define MAKE_DEV_ARGS(ppdev,args,...) \

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

• hselasky updated this revision to Diff 9883.Nov 2 2015, 3:03 PM
• hselasky retitled this revision from to Implement new make_dev_args() API.
• hselasky updated this object.
• hselasky edited the test plan for this revision. (Show Details)
• hselasky added reviewers: kib, rwatson, glebius, jhb.
• hselasky set the repository for this revision to rS FreeBSD src repository - subversion.
Herald added a subscriber: imp. · View Herald TranscriptNov 2 2015, 3:03 PM
• hselasky updated this revision to Diff 9884.Nov 2 2015, 3:06 PM

Compile fix.

• hselasky updated this revision to Diff 9885.Nov 2 2015, 3:10 PM

Update code style.

• hselasky added a comment.Dec 29 2015, 8:25 PM

Ping

kib edited edge metadata.EditedDec 31 2015, 3:45 PM

I am sorry, apparently I missed this review when you posted it.

I did prototyped very similar patch last time we talked. Differences are in the handling of the make_dev_args structure grow, I made it completely automatic without manual checks for the version. Also, I think my handling of (obsoleted) unit numbers is, in some sense, better.

I will put my variation onto review in a second.

UPDATE: D4746

kib mentioned this in D4746: make_dev_s().Dec 31 2015, 3:47 PM
• hselasky abandoned this revision.Jan 6 2016, 9:25 AM

Superceeded by D4746 .

Revision Contents
Changeset List

PathSize
sys/
kern/
135 lines
sys/
23 lines

Diff 9883

View Options

sys/kern/kern_conf.c

Show All 25 LinesFBSD_1.0 {
sigsetjmp; sigsetjmp;
siglongjmp; siglongjmp;
htonl; htonl;
htons; htons;
ntohl; ntohl;
ntohs; ntohs;
vfork; vfork;
brk; brk;
exect;
i386_clr_watch; i386_clr_watch;
i386_get_fsbase; i386_get_fsbase;
i386_get_gsbase; i386_get_gsbase;
i386_get_ioperm; i386_get_ioperm;
i386_get_ldt; i386_get_ldt;
i386_set_fsbase; i386_set_fsbase;
i386_set_gsbase; i386_set_gsbase;
i386_set_ioperm; i386_set_ioperm;
Show All 25 Lines
View Options

sys/sys/conf.h

Show All 25 LinesFBSD_1.0 {
sigsetjmp; sigsetjmp;
siglongjmp; siglongjmp;
htonl; htonl;
htons; htons;
ntohl; ntohl;
ntohs; ntohs;
vfork; vfork;
brk; brk;
exect;
i386_clr_watch; i386_clr_watch;
i386_get_fsbase; i386_get_fsbase;
i386_get_gsbase; i386_get_gsbase;
i386_get_ioperm; i386_get_ioperm;
i386_get_ldt; i386_get_ldt;
i386_set_fsbase; i386_set_fsbase;
i386_set_gsbase; i386_set_gsbase;
i386_set_ioperm; i386_set_ioperm;
Show All 25 Lines