netpfil tests: test removing interfaces with pending dummynet packets
ClosedPublic
Actions

Authored by kp on Nov 20 2021, 12:34 AM.

Details

Reviewers

glebius
jhb

Group Reviewers

network
pfsense

Commits

rG74e6b014b488: netpfil tests: test removing interfaces with pending dummynet packets

Summary

Dummynet queues packets with an associated struct ifnet pointer. Ensure
that things do not explode if that interface goes away with packets
still in the queue.

Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 42898
Build 39786: arc lint + arc unit

Event Timeline

kp created this revision.Nov 20 2021, 12:34 AM

Herald added subscribers: melifaro, imp. · View Herald TranscriptNov 20 2021, 12:34 AM

kp requested review of this revision.Nov 20 2021, 12:34 AM

Harbormaster completed remote builds in B42898: Diff 98769.Nov 20 2021, 12:34 AM

kp added a parent revision: D33064: dummynet: purge queued packets on interface destruction.Nov 20 2021, 12:34 AM

glebius accepted this revision.Nov 21 2021, 3:50 AM

This revision is now accepted and ready to land.Nov 21 2021, 3:50 AM

jhb accepted this revision.Nov 22 2021, 4:12 PM

This revision can be pushed. The tests shall no panic anymore.

Closed by commit rG74e6b014b488: netpfil tests: test removing interfaces with pending dummynet packets (authored by kp). · Explain WhyJan 27 2022, 9:21 AM

This revision was automatically updated to reflect the committed changes.

kp added a commit: rG74e6b014b488: netpfil tests: test removing interfaces with pending dummynet packets.

Revision Contents
Changeset List

Path

Size

tests/

sys/

netpfil/

common/

dummynet.sh

50 lines

Diff 98769

View Options

tests/sys/netpfil/common/dummynet.sh

netpfil tests: test removing interfaces with pending dummynet packetsClosedPublicActions