Page MenuHomeFreeBSD
Differential D33046

if_stf: minor man page improvements
ClosedPublic
Actions

Authored by kp on Nov 17 2021, 10:22 PM.
Tags
None
Referenced Files
F132217412: D33046.id98700.diff
Tue, Oct 14, 9:29 PM
Unknown Object (File)
Tue, Oct 14, 12:04 PM
Unknown Object (File)
Tue, Oct 14, 12:04 PM
Unknown Object (File)
Tue, Oct 14, 12:04 PM
Unknown Object (File)
Tue, Oct 14, 12:04 PM
Unknown Object (File)
Tue, Oct 14, 8:20 AM
Unknown Object (File)
Mon, Oct 13, 10:01 PM
Unknown Object (File)
Wed, Oct 1, 4:09 PM
View All Files
Subscribers
emaste
imp
pauamma_gundo.com

Details

Reviewers
None
Group Reviewers
network
pfsense
manpages
Commits
rG5dd9d0605aff: if_stf: minor man page improvements
Summary
  • fix typo (router -> routers)
  • Remove 6bone reference, because that was phased out in 2006.

Suggested by: Pau Amma <pauamma@gundo.com>
Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 42870
Build 39758: arc lint + arc unit

Event Timeline

kp created this revision.Nov 17 2021, 10:22 PM
Herald added a reviewer: manpages. · View Herald TranscriptNov 17 2021, 10:22 PM
Herald added a subscriber: imp. · View Herald Transcript
kp requested review of this revision.Nov 17 2021, 10:22 PM
Harbormaster completed remote builds in B42852: Diff 98663.Nov 17 2021, 10:22 PM
kp added a parent revision: D33042: if_stf: document 6rd in the man page.Nov 17 2021, 10:22 PM
pauamma_gundo.com added a subscriber: pauamma_gundo.com.Nov 18 2021, 12:35 AM

LGTM.

emaste added a subscriber: emaste.Nov 18 2021, 2:26 AM
emaste added inline comments.
share/man/man4/stf.4
62

should this be plural as well? or "necessary for a site border router (called ..."?

kp updated this revision to Diff 98700.Nov 18 2021, 4:34 PM

Border routerS

Harbormaster completed remote builds in B42870: Diff 98700.Nov 18 2021, 4:34 PM
pauamma_gundo.com added inline comments.Nov 18 2021, 9:36 PM
share/man/man4/stf.4
64

In that case, this needs to be pluralized as well for consistency.

kp added inline comments.Nov 19 2021, 6:12 PM
share/man/man4/stf.4
64

It currently reads

"For ordinary nodes in a 6to4 or 6RD site, you do not need stf interface.
  The stf interface is necessary for site border routers (called “6to4
  routers” or “6rd Customer Edge (CE)” in the specification)."

I don't think Customer Edges would improve that.

This revision was not accepted when it landed; it landed in state Needs Review.Nov 20 2021, 7:05 PM
Closed by commit rG5dd9d0605aff: if_stf: minor man page improvements (authored by kp). · Explain Why
This revision was automatically updated to reflect the committed changes.
kp added a commit: rG5dd9d0605aff: if_stf: minor man page improvements.

Revision Contents
Changeset List

PathSize
share/
man/
man4/
6 lines

Diff 98700

View Options

share/man/man4/stf.4

Loading...