Differential D32991

loader: lsefi: Print more information
ClosedPublic
Actions

Authored by manu on Nov 15 2021, 12:58 PM.

Tags

None

Referenced Files

	F103979101: D32991.diff
	Sun, Dec 1, 11:48 PM

	Unknown Object (File)
	Sun, Nov 24, 12:26 PM

	Unknown Object (File)
	Fri, Nov 15, 2:51 AM

	Unknown Object (File)
	Fri, Nov 15, 12:30 AM

	Unknown Object (File)
	Sun, Nov 3, 1:09 PM

	Unknown Object (File)
	Sun, Nov 3, 1:08 PM

	Unknown Object (File)
	Sun, Nov 3, 1:08 PM

	Unknown Object (File)
	Sun, Nov 3, 12:53 PM

View All 52 Files

Subscribers

Details

Reviewers

tsoome
imp
kevans

Group Reviewers

Commits

rG50af79ac2d71: loader: lsefi: Print more information
rG2e0d67c3ed7e: loader: lsefi: Print more information

Summary

Printing the EFI_HANDLE pointer isn't very useful.
If the handle have a IMAGE_DEVICE_PATH or a DEVICE_PATH protocol print it.
This makes it easier to see which devices are present and what protocol they
expose.

Sponsored by: Beckhoff Automation GmbH & Co. KG

Test Plan

Tested on u-boot based and edk2 based firmware

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

manu created this revision.Nov 15 2021, 12:58 PM

Herald added subscribers: dab, bcran. · View Herald TranscriptNov 15 2021, 12:58 PM

manu requested review of this revision.Nov 15 2021, 12:58 PM

lwhsu edited reviewers, added: Loader; removed: loader.Nov 15 2021, 3:34 PM

It's better than what we have as is... Question about whether or not we have multiple paths that would be useful or not (I can't recall that deatil). If so, please adjust to print both (I still approve), if not just indicate in comments (and I also still approve)

stand/efi/loader/main.c
1417	Can you have both an image path and a devpath for the handle? And would you want to print them both?

This revision is now accepted and ready to land.Nov 15 2021, 3:41 PM

manu added inline comments.Nov 15 2021, 3:47 PM

stand/efi/loader/main.c
1417	You can't if I understand correctly the UEFI driver model.

imp added inline comments.Nov 15 2021, 3:56 PM

stand/efi/loader/main.c
1417	OK then. forget I said anything... I wasn't quite sure... feel free to commit when you think the review is complete.

tsoome accepted this revision.Nov 15 2021, 4:15 PM

Closed by commit rG2e0d67c3ed7e: loader: lsefi: Print more information (authored by manu). · Explain WhyNov 16 2021, 9:12 AM

This revision was automatically updated to reflect the committed changes.

manu added a commit: rG2e0d67c3ed7e: loader: lsefi: Print more information.

manu added a commit: rG50af79ac2d71: loader: lsefi: Print more information.Jan 14 2022, 1:43 PM

Revision Contents
Changeset List

Path

Size

stand/

efi/

loader/

26 lines

Diff 98504

stand/efi/loader/main.c

Loading...