Rename net.inet.ip.check_interface to rfc1122_strong_es and document it.
ClosedPublic
Actions

Authored by glebius on Nov 9 2021, 8:33 PM.

Details

Reviewers

donner
kp

Group Reviewers

manpages
network

Commits

rG94df3271d6b2: Rename net.inet.ip.check_interface to rfc1122_strong_es and document it.

Summary

This very questionable feature was enabled in FreeBSD for a very short
time. It was disabled very soon upon merging to RELENG_4 - 23d7f14119bf.
And in HEAD was also disabled pretty soon - 4bc37f9836fb1.

The tunable has very vague name. Check interface for what? Given that
it was never documented and almost never enabled, I think it is fine
to rename it together with documenting it.

Also, count packets dropped by this tunable as ips_badaddr, otherwise
they fall down to ips_cantforward counter, which is misleading, as
packet was not supposed to be forwarded, it was destined locally.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 42681
Build 39569: arc lint + arc unit

Event Timeline

glebius created this revision.Nov 9 2021, 8:33 PM

Herald added a reviewer: manpages. · View Herald TranscriptNov 9 2021, 8:33 PM

Herald added subscribers: melifaro, imp. · View Herald Transcript

glebius requested review of this revision.Nov 9 2021, 8:33 PM

Harbormaster completed remote builds in B42681: Diff 98267.Nov 9 2021, 8:33 PM

glebius added a reviewer: network.Nov 9 2021, 8:34 PM

glebius added a child revision: D32913: ip_input: packet filters shall not modify m_pkthdr.rcvif.Nov 9 2021, 8:34 PM

Others call this "host model" instead of "end system", hence I was confused without reading the documentation.

This revision is now accepted and ready to land.Nov 9 2021, 9:39 PM

kp accepted this revision as: kp.Nov 10 2021, 9:46 AM

kp added a subscriber: kp.

kp added inline comments.

share/man/man4/inet.4
211	That doesn't read quite right, I think. Maybe "If a packet with a local destination address"? Or maybe a native speaker will have a better suggestion.

glebius added inline comments.Nov 12 2021, 6:34 AM

share/man/man4/inet.4
211	I asked couple native speakers for help and both found it challenging thing to describe the feature succinctly and clearly. Maybe that's why it originally was named so vaguely and left undocumented? :) If I don't get any good advice in a day, I'm going to commit as is and let it be improved post commit.