Tags

None

Referenced Files

	F137291798: D32106.id95640.diff
	Sat, Nov 22, 3:14 AM

	Unknown Object (File)
	Fri, Nov 21, 9:40 PM

	Unknown Object (File)
	Wed, Nov 19, 12:30 PM

	Unknown Object (File)
	Sun, Nov 16, 5:29 AM

	Unknown Object (File)
	Sat, Nov 15, 5:45 PM

	Unknown Object (File)
	Sat, Nov 15, 2:25 PM

	Unknown Object (File)
	Wed, Nov 5, 1:54 PM

	Unknown Object (File)
	Mon, Nov 3, 3:23 PM

Subscribers

Details

Reviewers

markj

Commits

rGd1d4ac2dbd70: cryptosoft, ccr: Use crp_iv directly for AES-CCM and AES-GCM.
rG5ae5ed5b8fd2: cryptosoft, ccr: Use crp_iv directly for AES-CCM and AES-GCM.

Summary

Rather than copying crp_iv to a local array on the stack that is then
passed to xform reinit routines, pass crp_iv directly and remove the
local copy.

Sponsored by: Chelsio Communications, The FreeBSD Foundation

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Sep 24 2021, 6:04 PM

Herald added subscribers: ae, jmg, imp. · View Herald TranscriptSep 24 2021, 6:04 PM

jhb requested review of this revision.Sep 24 2021, 6:04 PM

jhb added a parent revision: D32105: crypto: Permit variable-sized IVs for ciphers with a reinit hook..

jhb added a child revision: D32107: cryptodev: Permit explicit IV/nonce and MAC/tag lengths..

Harbormaster completed remote builds in B41707: Diff 95640.Sep 24 2021, 6:05 PM

jhb added a reviewer: markj.Sep 27 2021, 9:32 PM

markj accepted this revision.Sep 28 2021, 3:41 PM

This revision is now accepted and ready to land.Sep 28 2021, 3:41 PM

Closed by commit rG5ae5ed5b8fd2: cryptosoft, ccr: Use crp_iv directly for AES-CCM and AES-GCM. (authored by jhb). · Explain WhyOct 6 2021, 9:10 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rG5ae5ed5b8fd2: cryptosoft, ccr: Use crp_iv directly for AES-CCM and AES-GCM..

jhb added a commit: rGd1d4ac2dbd70: cryptosoft, ccr: Use crp_iv directly for AES-CCM and AES-GCM..Oct 21 2021, 10:04 PM

cryptosoft, ccr: Use crp_iv directly for AES-CCM and AES-GCM.
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 96375

sys/dev/cxgbe/crypto/t4_crypto.c

sys/opencrypto/cryptosoft.c

cryptosoft, ccr: Use crp_iv directly for AES-CCM and AES-GCM.ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 96375

sys/dev/cxgbe/crypto/t4_crypto.c

sys/opencrypto/cryptosoft.c

cryptosoft, ccr: Use crp_iv directly for AES-CCM and AES-GCM.
ClosedPublic
Actions

Revision Contents
Changeset List