Page MenuHomeFreeBSD
Differential D32075

sdhci: Fix crash caused by M_WAITOK in sdhci dumps
ClosedPublic
Actions

Authored by bag_semihalf.com on Sep 23 2021, 8:38 AM.
Tags
None
Referenced Files
F140467192: D32075.diff
Wed, Dec 24, 6:40 AM
Unknown Object (File)
Sun, Dec 21, 7:45 AM
Unknown Object (File)
Fri, Dec 5, 6:01 AM
Unknown Object (File)
Nov 5 2025, 4:23 AM
Unknown Object (File)
Nov 3 2025, 5:54 PM
Unknown Object (File)
Nov 3 2025, 5:21 PM
Unknown Object (File)
Nov 2 2025, 6:42 AM
Unknown Object (File)
Oct 29 2025, 12:04 PM
View All 97 Files
Subscribers
dgr_semihalf.com
imp
kd

Details

Reviewers
mjg
manu
mw
wma
Commits
rG3ac5012e52ee: sdhci: Fix crash caused by M_WAITOK in sdhci dumps
Summary

In some contexts it is illegal to wait for memory allocation, causing
kernel panic. By default sbuf_new passes M_WAITOK to malloc,
which caused crashes when sdhci_dumpcaps or sdhci_dumpregs was callend in
non sutiable context.

Add SBUF_NOWAIT flag to sbuf_new to fix this.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bag_semihalf.com requested review of this revision.Sep 23 2021, 8:38 AM
bag_semihalf.com created this revision.
This revision was not accepted when it landed; it landed in state Needs Review.Oct 5 2021, 4:24 AM
Closed by commit rG3ac5012e52ee: sdhci: Fix crash caused by M_WAITOK in sdhci dumps (authored by bag_semihalf.com, committed by wma). · Explain Why
This revision was automatically updated to reflect the committed changes.
wma added a commit: rG3ac5012e52ee: sdhci: Fix crash caused by M_WAITOK in sdhci dumps.
Herald added a subscriber: imp. · View Herald TranscriptOct 5 2021, 4:24 AM

Revision Contents
Changeset List

PathSize
sys/
dev/
sdhci/
12 lines

Diff 96257

View Options

sys/dev/sdhci/sdhci.c

Loading...