Page MenuHomeFreeBSD
Differential D31748

pf: Support clearing ether counters
ClosedPublic
Actions

Authored by kp on Aug 31 2021, 8:27 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Mar 29, 1:00 AM
Unknown Object (File)
Tue, Mar 25, 2:08 PM
Unknown Object (File)
Fri, Mar 21, 12:35 AM
Unknown Object (File)
Sat, Mar 15, 7:53 PM
Unknown Object (File)
Feb 25 2025, 1:26 PM
Unknown Object (File)
Feb 25 2025, 11:35 AM
Unknown Object (File)
Feb 25 2025, 11:22 AM
Unknown Object (File)
Feb 25 2025, 11:02 AM
View All Files
Subscribers
farrokhi
glebius
imp
melifaro

Details

Reviewers
None
Group Reviewers
network
pfsense
Commits
rG30087aa2e00a: pf: Support clearing ether counters
Summary

Allow the evaluations/packets/bytes counters on Ethernet rules to be
cleared.

Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 41838
Build 38726: arc lint + arc unit

Event Timeline

kp created this revision.Aug 31 2021, 8:27 AM
Herald added subscribers: melifaro, farrokhi, imp. · View Herald TranscriptAug 31 2021, 8:27 AM
kp requested review of this revision.Aug 31 2021, 8:27 AM
Harbormaster completed remote builds in B41287: Diff 94424.Aug 31 2021, 8:27 AM
kp added a parent revision: D31747: pf tests: Test ether direction.Aug 31 2021, 8:27 AM
kp added a child revision: D31749: pfctl: Don't print (ether) to / from if they're not set.
kp updated this revision to Diff 95945.Sep 29 2021, 3:03 PM

Rebase

Harbormaster completed remote builds in B41838: Diff 95945.Sep 29 2021, 3:03 PM
kp updated this revision to Diff 96822.Oct 13 2021, 3:33 PM

Rebase

Harbormaster completed remote builds in B42115: Diff 96822.Oct 13 2021, 3:33 PM
This revision was not accepted when it landed; it landed in state Needs Review.Mar 2 2022, 4:01 PM
Closed by commit rG30087aa2e00a: pf: Support clearing ether counters (authored by kp). · Explain Why
This revision was automatically updated to reflect the committed changes.
kp added a commit: rG30087aa2e00a: pf: Support clearing ether counters.
Herald added a subscriber: glebius. · View Herald TranscriptMar 2 2022, 4:01 PM

Revision Contents
Changeset List

PathSize
sbin/
pfctl/
16 lines
sys/
netpfil/
pf/
15 lines

Diff 95945

View Options

sbin/pfctl/pfctl.c

Context not available.
}; };
*/ */
{ {
struct inode *ip;
struct fs *fs;
ip = VTOI(ap->a_vp);
fs = ip->i_fs;
if (ap->a_vp->v_type == VCHR || ap->a_vp->v_type == VBLK) if (ap->a_vp->v_type == VCHR || ap->a_vp->v_type == VBLK)
return (EOPNOTSUPP); return (EOPNOTSUPP);
Context not available.
}; };
*/ */
{ {
struct inode *ip;
struct fs *fs;
ip = VTOI(ap->a_vp);
fs = ip->i_fs;
if (ap->a_vp->v_type == VCHR || ap->a_vp->v_type == VBLK) if (ap->a_vp->v_type == VCHR || ap->a_vp->v_type == VBLK)
return (EOPNOTSUPP); return (EOPNOTSUPP);
Context not available.
*/ */
{ {
struct inode *ip; struct inode *ip;
struct fs *fs;
u_char *eae, *p; u_char *eae, *p;
unsigned easize; unsigned easize;
int error, ealen; int error, ealen;
ip = VTOI(ap->a_vp); ip = VTOI(ap->a_vp);
fs = ip->i_fs;
if (ap->a_vp->v_type == VCHR || ap->a_vp->v_type == VBLK) if (ap->a_vp->v_type == VCHR || ap->a_vp->v_type == VBLK)
return (EOPNOTSUPP); return (EOPNOTSUPP);
Context not available.
*/ */
{ {
struct inode *ip; struct inode *ip;
struct fs *fs;
u_char *eae, *p, *pe, *pn; u_char *eae, *p, *pe, *pn;
unsigned easize; unsigned easize;
uint32_t ul; uint32_t ul;
int error, ealen; int error, ealen;
ip = VTOI(ap->a_vp); ip = VTOI(ap->a_vp);
fs = ip->i_fs;
if (ap->a_vp->v_type == VCHR || ap->a_vp->v_type == VBLK) if (ap->a_vp->v_type == VCHR || ap->a_vp->v_type == VBLK)
return (EOPNOTSUPP); return (EOPNOTSUPP);
Context not available.
View Options

sys/netpfil/pf/pf_ioctl.c

Context not available.
}; };
*/ */
{ {
struct inode *ip;
struct fs *fs;
ip = VTOI(ap->a_vp);
fs = ip->i_fs;
if (ap->a_vp->v_type == VCHR || ap->a_vp->v_type == VBLK) if (ap->a_vp->v_type == VCHR || ap->a_vp->v_type == VBLK)
return (EOPNOTSUPP); return (EOPNOTSUPP);
Context not available.
}; };
*/ */
{ {
struct inode *ip;
struct fs *fs;
ip = VTOI(ap->a_vp);
fs = ip->i_fs;
if (ap->a_vp->v_type == VCHR || ap->a_vp->v_type == VBLK) if (ap->a_vp->v_type == VCHR || ap->a_vp->v_type == VBLK)
return (EOPNOTSUPP); return (EOPNOTSUPP);
Context not available.
*/ */
{ {
struct inode *ip; struct inode *ip;
struct fs *fs;
u_char *eae, *p; u_char *eae, *p;
unsigned easize; unsigned easize;
int error, ealen; int error, ealen;
ip = VTOI(ap->a_vp); ip = VTOI(ap->a_vp);
fs = ip->i_fs;
if (ap->a_vp->v_type == VCHR || ap->a_vp->v_type == VBLK) if (ap->a_vp->v_type == VCHR || ap->a_vp->v_type == VBLK)
return (EOPNOTSUPP); return (EOPNOTSUPP);
Context not available.
*/ */
{ {
struct inode *ip; struct inode *ip;
struct fs *fs;
u_char *eae, *p, *pe, *pn; u_char *eae, *p, *pe, *pn;
unsigned easize; unsigned easize;
uint32_t ul; uint32_t ul;
int error, ealen; int error, ealen;
ip = VTOI(ap->a_vp); ip = VTOI(ap->a_vp);
fs = ip->i_fs;
if (ap->a_vp->v_type == VCHR || ap->a_vp->v_type == VBLK) if (ap->a_vp->v_type == VCHR || ap->a_vp->v_type == VBLK)
return (EOPNOTSUPP); return (EOPNOTSUPP);
Context not available.