cryptosoft, ccr: Use crp_iv directly for AES-CCM and AES-GCM.
ClosedPublic
Actions

Authored by jhb on Sep 24 2021, 6:04 PM.

Details

Reviewers

Commits

rGd1d4ac2dbd70: cryptosoft, ccr: Use crp_iv directly for AES-CCM and AES-GCM.
rG5ae5ed5b8fd2: cryptosoft, ccr: Use crp_iv directly for AES-CCM and AES-GCM.

Summary

Rather than copying crp_iv to a local array on the stack that is then
passed to xform reinit routines, pass crp_iv directly and remove the
local copy.

Sponsored by: Chelsio Communications, The FreeBSD Foundation

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 41707
Build 38596: arc lint + arc unit

Event Timeline

jhb created this revision.Sep 24 2021, 6:04 PM

Herald added subscribers: ae, jmg, imp. · View Herald TranscriptSep 24 2021, 6:04 PM

jhb requested review of this revision.Sep 24 2021, 6:04 PM

jhb added a parent revision: D32105: crypto: Permit variable-sized IVs for ciphers with a reinit hook..

jhb added a child revision: D32107: cryptodev: Permit explicit IV/nonce and MAC/tag lengths..

Harbormaster completed remote builds in B41707: Diff 95640.Sep 24 2021, 6:05 PM

jhb added a reviewer: markj.Sep 27 2021, 9:32 PM

markj accepted this revision.Sep 28 2021, 3:41 PM

This revision is now accepted and ready to land.Sep 28 2021, 3:41 PM

Closed by commit rG5ae5ed5b8fd2: cryptosoft, ccr: Use crp_iv directly for AES-CCM and AES-GCM. (authored by jhb). · Explain WhyOct 6 2021, 9:10 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rG5ae5ed5b8fd2: cryptosoft, ccr: Use crp_iv directly for AES-CCM and AES-GCM..

jhb added a commit: rGd1d4ac2dbd70: cryptosoft, ccr: Use crp_iv directly for AES-CCM and AES-GCM..Oct 21 2021, 10:04 PM

Revision Contents
Changeset List

Path

Size

sys/

dev/

cxgbe/

crypto/

t4_crypto.c

17 lines

opencrypto/

cryptosoft.c

18 lines

Diff 95640

View Options

sys/dev/cxgbe/crypto/t4_crypto.c