Page MenuHomeFreeBSD

sctp: Fix lock recursion in sctp_swap_inpcb_for_listen()
ClosedPublic

Authored by markj on Sep 8 2021, 3:06 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Aug 12, 5:11 PM
Unknown Object (File)
Tue, Aug 11, 3:20 PM
Unknown Object (File)
Mon, Aug 10, 6:43 AM
Unknown Object (File)
Mon, Aug 10, 6:17 AM
Unknown Object (File)
Fri, Aug 7, 7:34 PM
Unknown Object (File)
Fri, Aug 7, 4:01 PM
Unknown Object (File)
Fri, Aug 7, 3:48 PM
Unknown Object (File)
Fri, Aug 7, 2:29 PM
Subscribers

Details

Summary

After commit bd4a39cc93d9 we now hold the global inp info lock across
the call to sctp_swap_inpcb_for_listen(), which attempts to acquire it
again. Since sctp_swap_inpcb_for_listen()'s sole caller is
sctp_listen(), we can simply change it to not try to acquire the lock.

Fixes: bd4a39cc93d9 ("socket: Properly interlock when transitioning to a listening socket")
Reported by: syzkaller

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable