Differential D31705

vfs: yield in vn_deallocate_impl() loop
ClosedPublic
Actions

Authored by khng on Aug 27 2021, 10:45 PM.

Tags

None

Referenced Files

	F169288926: D31705.id94294.diff
	Tue, Sep 1, 3:31 AM

	F169259324: D31705.id.diff
	Tue, Sep 1, 2:10 AM

	Unknown Object (File)
	Mon, Aug 31, 7:05 AM

	Unknown Object (File)
	Sun, Aug 30, 5:06 PM

	Unknown Object (File)
	Sun, Aug 30, 12:28 PM

	Unknown Object (File)
	Sun, Aug 30, 6:35 AM

	Unknown Object (File)
	Sat, Aug 29, 10:00 PM

	Unknown Object (File)
	Fri, Aug 28, 11:47 PM

Subscribers

Details

Reviewers

Commits

rGa58e222b3bcc: vfs: yield in vn_deallocate_impl() loop

Summary

Yield at the end of each loop iteration if there are remaining works as
indicated by the value of *len updated by VOP_DEALLOCATE. Without this,
when calling vop_stddeallocate to zero a large region, the
implementation only zerofills a relatively small chunk and return.

Sponsored by: The FreeBSD Foundation

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

khng created this revision.Aug 27 2021, 10:45 PM

Herald added a subscriber: imp. · View Herald TranscriptAug 27 2021, 10:45 PM

khng requested review of this revision.Aug 27 2021, 10:45 PM

Harbormaster completed remote builds in B41241: Diff 94294.Aug 27 2021, 10:45 PM

Do not call maybe_yield if there is any error

Harbormaster completed remote builds in B41242: Diff 94295.Aug 27 2021, 10:57 PM

kib accepted this revision.Aug 28 2021, 7:50 PM

This revision is now accepted and ready to land.Aug 28 2021, 7:50 PM

Closed by commit rGa58e222b3bcc: vfs: yield in vn_deallocate_impl() loop (authored by khng). · Explain WhyAug 29 2021, 8:27 AM

This revision was automatically updated to reflect the committed changes.

khng added a commit: rGa58e222b3bcc: vfs: yield in vn_deallocate_impl() loop.

Revision Contents
Changeset List

Path

Size

sys/

kern/

2 lines

Diff 94318

sys/kern/vfs_vnops.c

Loading...