Differential D31671

fsetown: Avoid gotos for error handling
ClosedPublic
Actions

Authored by markj on Aug 24 2021, 9:08 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Apr 18, 4:11 PM

	Unknown Object (File)
	Fri, Apr 18, 11:15 AM

	Unknown Object (File)
	Fri, Apr 18, 6:38 AM

	Unknown Object (File)
	Feb 7 2025, 8:01 AM

	Unknown Object (File)
	Jan 25 2025, 7:31 PM

	Unknown Object (File)
	Jan 25 2025, 7:20 PM

	Unknown Object (File)
	Jan 16 2025, 11:58 PM

	Unknown Object (File)
	Jan 16 2025, 7:41 PM

View All 96 Files

Subscribers

Details

Reviewers

Commits

rGa507a40f3b58: fsetown: Simplify error handling

Summary

This simplifies control flow somewhat at the expense of extra nesting.

Suggested by: kib

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.Aug 24 2021, 9:08 PM

Herald added a subscriber: imp. · View Herald TranscriptAug 24 2021, 9:08 PM

markj requested review of this revision.Aug 24 2021, 9:08 PM

Harbormaster completed remote builds in B41190: Diff 94143.Aug 24 2021, 9:08 PM

markj mentioned this in D31661: Fix a pair of bugs in fsetown().Aug 24 2021, 9:10 PM

kib accepted this revision.Aug 24 2021, 10:28 PM

This revision is now accepted and ready to land.Aug 24 2021, 10:28 PM

Closed by commit rGa507a40f3b58: fsetown: Simplify error handling (authored by markj). · Explain WhyAug 25 2021, 8:31 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rGa507a40f3b58: fsetown: Simplify error handling.

Revision Contents
Changeset List

Path

Size

sys/

kern/

106 lines

Diff 94191

sys/kern/kern_descrip.c

Context not available.
	netinet/tcp_lro.c optional inet \| inet6			netinet/tcp_lro.c optional inet \| inet6
	netinet/tcp_output.c optional inet \| inet6			netinet/tcp_output.c optional inet \| inet6
	netinet/tcp_offload.c optional tcp_offload inet \| tcp_offload inet6			netinet/tcp_offload.c optional tcp_offload inet \| tcp_offload inet6
				netinet/tcp_hpts.c optional tcphpts inet \| tcphpts inet6
	netinet/tcp_pcap.c optional inet tcppcap \| inet6 tcppcap			netinet/tcp_pcap.c optional inet tcppcap \| inet6 tcppcap
	netinet/tcp_reass.c optional inet \| inet6			netinet/tcp_reass.c optional inet \| inet6
	netinet/tcp_sack.c optional inet \| inet6			netinet/tcp_sack.c optional inet \| inet6
Context not available.