Page MenuHomeFreeBSD

tmpfs: Move partial page invalidation to a separate helper
ClosedPublic

Authored by khng on Aug 25 2021, 8:13 PM.
Tags
None
Referenced Files
F160456222: D31683.id94200.diff
Wed, Jun 24, 4:14 PM
F160453328: D31683.id94188.diff
Wed, Jun 24, 3:18 PM
Unknown Object (File)
Tue, Jun 23, 10:30 AM
Unknown Object (File)
Sat, Jun 20, 9:34 PM
Unknown Object (File)
May 15 2026, 11:10 PM
Unknown Object (File)
May 15 2026, 6:42 PM
Unknown Object (File)
May 15 2026, 6:42 PM
Unknown Object (File)
May 2 2026, 12:11 PM
Subscribers

Details

Summary

The partial page invalidation code is factored out to be a separate
helper from tmpfs_reg_resize().

Sponsored by: The FreeBSD Foundation

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 41210
Build 38099: arc lint + arc unit

Event Timeline

khng requested review of this revision.Aug 25 2021, 8:13 PM
sys/fs/tmpfs/tmpfs_subr.c
404

Replace the whole 'else' branch with something along the lines:

vm_page_free(m);
m = NULL;
if (!ignerr)
    error = EIO;

and change return (0); at the end with return (error);

1755

By convention 'rv' var holds a Mach error code, not errno. Since tmpfs_partial_page_invalidate() returns errno, better rename rv there.

khng marked 2 inline comments as done.

Cleanups suggested by kib@

This revision is now accepted and ready to land.Aug 25 2021, 8:50 PM