Page MenuHomeFreeBSD
Differential D31683

tmpfs: Move partial page invalidation to a separate helper
ClosedPublic
Actions

Authored by khng on Aug 25 2021, 8:13 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Sep 9, 3:40 PM
Unknown Object (File)
Mon, Sep 7, 10:26 PM
Unknown Object (File)
Mon, Sep 7, 10:25 PM
Unknown Object (File)
Sun, Sep 6, 1:35 AM
Unknown Object (File)
Sat, Sep 5, 2:33 PM
Unknown Object (File)
Sat, Sep 5, 10:43 AM
Unknown Object (File)
Sat, Sep 5, 1:32 AM
Unknown Object (File)
Fri, Sep 4, 2:04 PM
View All Files
Subscribers
imp

Details

Reviewers
markj
kib
Commits
rGb31e93bc8d11: tmpfs: Move partial page invalidation to a separate helper
rG399be91098ad: tmpfs: Move partial page invalidation to a separate helper
Summary

The partial page invalidation code is factored out to be a separate
helper from tmpfs_reg_resize().

Sponsored by: The FreeBSD Foundation

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 41213
Build 38102: arc lint + arc unit

Event Timeline

khng created this revision.Aug 25 2021, 8:13 PM
Herald added a subscriber: imp. · View Herald TranscriptAug 25 2021, 8:13 PM
khng requested review of this revision.Aug 25 2021, 8:13 PM
Harbormaster completed remote builds in B41210: Diff 94188.Aug 25 2021, 8:13 PM
khng added a child revision: D31684: tmpfs: Implement VOP_DEALLOCATE.Aug 25 2021, 8:13 PM
kib added inline comments.Aug 25 2021, 8:32 PM
sys/fs/tmpfs/tmpfs_subr.c
404

Replace the whole 'else' branch with something along the lines:

vm_page_free(m);
m = NULL;
if (!ignerr)
    error = EIO;

and change return (0); at the end with return (error);

1755–1757

By convention 'rv' var holds a Mach error code, not errno. Since tmpfs_partial_page_invalidate() returns errno, better rename rv there.

khng updated this revision to Diff 94193.Aug 25 2021, 8:44 PM
khng marked 2 inline comments as done.

Cleanups suggested by kib@

Harbormaster completed remote builds in B41213: Diff 94193.Aug 25 2021, 8:44 PM
kib accepted this revision.Aug 25 2021, 8:50 PM
This revision is now accepted and ready to land.Aug 25 2021, 8:50 PM
Closed by commit rG399be91098ad: tmpfs: Move partial page invalidation to a separate helper (authored by khng). · Explain WhyAug 25 2021, 9:35 PM
This revision was automatically updated to reflect the committed changes.
khng added a commit: rG399be91098ad: tmpfs: Move partial page invalidation to a separate helper.
khng added a commit: rGb31e93bc8d11: tmpfs: Move partial page invalidation to a separate helper.Sep 3 2021, 5:25 PM

Revision Contents
Changeset List

PathSize
sys/
fs/
tmpfs/
96 lines

Diff 94193

View Options

sys/fs/tmpfs/tmpfs_subr.c

Loading...