Page MenuHomeFreeBSD

tmpfs: Move partial page invalidation to a separate helper
ClosedPublic

Authored by khng on Aug 25 2021, 8:13 PM.
Tags
None
Referenced Files
F139478619: D31683.diff
Fri, Dec 12, 1:43 PM
Unknown Object (File)
Tue, Dec 2, 2:20 AM
Unknown Object (File)
Fri, Nov 28, 2:11 AM
Unknown Object (File)
Thu, Nov 27, 6:41 AM
Unknown Object (File)
Wed, Nov 19, 1:39 AM
Unknown Object (File)
Oct 17 2025, 8:55 AM
Unknown Object (File)
Oct 16 2025, 8:48 PM
Unknown Object (File)
Oct 16 2025, 8:48 PM
Subscribers

Details

Summary

The partial page invalidation code is factored out to be a separate
helper from tmpfs_reg_resize().

Sponsored by: The FreeBSD Foundation

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 41210
Build 38099: arc lint + arc unit

Event Timeline

khng requested review of this revision.Aug 25 2021, 8:13 PM
sys/fs/tmpfs/tmpfs_subr.c
404

Replace the whole 'else' branch with something along the lines:

vm_page_free(m);
m = NULL;
if (!ignerr)
    error = EIO;

and change return (0); at the end with return (error);

1755

By convention 'rv' var holds a Mach error code, not errno. Since tmpfs_partial_page_invalidate() returns errno, better rename rv there.

khng marked 2 inline comments as done.

Cleanups suggested by kib@

This revision is now accepted and ready to land.Aug 25 2021, 8:50 PM