Paths

Table of Contentst

Differential D31223

cxgbei: Support for ISO (iSCSI segmentation offload).
ClosedPublic
Actions

Authored by jhb on Jul 19 2021, 10:21 PM.

Tags

None

Referenced Files

	F132564980: D31223.diff
	Sat, Oct 18, 12:44 AM

	Unknown Object (File)
	Wed, Oct 8, 9:55 AM

	Unknown Object (File)
	Sat, Oct 4, 1:36 PM

	Unknown Object (File)
	Mon, Sep 22, 11:20 AM

	Unknown Object (File)
	Sep 17 2025, 11:40 PM

	Unknown Object (File)
	Sep 13 2025, 1:42 AM

	Unknown Object (File)
	Sep 10 2025, 9:41 PM

	Unknown Object (File)
	Sep 8 2025, 3:02 AM

View All 89 Files

Subscribers

Details

Reviewers

mav
np
trasz

Commits

rG132894ca4beb: cxgbei: Support for ISO (iSCSI segmentation offload).
rG5b27e4b27caa: cxgbei: Support for ISO (iSCSI segmentation offload).

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 40759
Build 37648: arc lint + arc unit

Event Timeline

jhb created this revision.Jul 19 2021, 10:21 PM

Herald added subscribers: ae, imp. · View Herald TranscriptJul 19 2021, 10:21 PM

jhb requested review of this revision.Jul 19 2021, 10:21 PM

jhb added a parent revision: D31222: iSCSI: Add support for segmentation offload for hardware offloads..

Harbormaster completed remote builds in B40538: Diff 92440.Jul 19 2021, 10:22 PM

jhb added inline comments.Jul 19 2021, 10:52 PM

sys/dev/cxgbe/cxgbei/icl_cxgbei.c
861	I'm just not sure what header this would go in. It seems like something that would perhaps belong in a common t4_foo.h header?
872–874	When I tried this setting, it didn't work, so possibly I should just drop this comment.

jhb added inline comments.Jul 29 2021, 9:48 PM

sys/dev/cxgbe/cxgbei/icl_cxgbei.c
861	I've renamed this to `CXGBEI_MAX_ISO_PAYLOAD` and moved it to cxgbei.h.
872–874	When I tried this setting, it didn't work, so possibly I should just drop this comment. We've since had to debug an issue with this particular value internally and I've changed the expression that goes here. I'll update this patch when the updated version when it's ready.

Some cleanups to PLEN_MAX.
Add a knob to disable ISO.
Disable ISO on T4.

Harbormaster completed remote builds in B40759: Diff 93003.Jul 30 2021, 8:58 PM

This revision was not accepted when it landed; it landed in state Needs Review.Aug 6 2021, 9:30 PM

Closed by commit rG5b27e4b27caa: cxgbei: Support for ISO (iSCSI segmentation offload). (authored by jhb). · Explain Why

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rG5b27e4b27caa: cxgbei: Support for ISO (iSCSI segmentation offload)..

jhb added a commit: rG132894ca4beb: cxgbei: Support for ISO (iSCSI segmentation offload)..Oct 30 2021, 12:01 AM

Revision Contents
Changeset List

Path

Size

sys/

dev/

cxgbe/

1 line

cxgbei/

2 lines

62 lines

1 line

5 lines

5 lines

tom/

184 lines

52 lines

Diff 93003

sys/dev/cxgbe/adapter.h

Loading...

sys/dev/cxgbe/cxgbei/cxgbei.h

Loading...

sys/dev/cxgbe/cxgbei/icl_cxgbei.c

Loading...

sys/dev/cxgbe/offload.h

Loading...

sys/dev/cxgbe/t4_main.c

Loading...

sys/dev/cxgbe/t4_sge.c

Loading...

sys/dev/cxgbe/tom/t4_cpl_io.c

Loading...

sys/dev/cxgbe/tom/t4_tom.h

Loading...