Page MenuHomeFreeBSD
Differential D31334

hwpmc: remove static POWER8 definitions
ClosedPublic
Actions

Authored by luporl on Jul 28 2021, 4:54 PM.
Tags
None
Referenced Files
F82411669: D31334.id.diff
Sun, Apr 28, 8:42 AM
Unknown Object (File)
Sat, Apr 27, 1:44 AM
Unknown Object (File)
Wed, Apr 24, 2:10 AM
Unknown Object (File)
Tue, Apr 23, 6:46 PM
Unknown Object (File)
Jan 12 2024, 6:14 PM
Unknown Object (File)
Jan 11 2024, 1:58 AM
Unknown Object (File)
Jan 10 2024, 9:04 PM
Unknown Object (File)
Jan 2 2024, 8:39 PM
View All 27 Files
Subscribers
imp

Details

Reviewers
mhorne
leonardo.bianconi_eldorado.org.br
kbowling
gnn
Group Reviewers
PowerPC
Commits
rG95d619a8ea1f: hwpmc: remove static POWER8 definitions
Summary

After b48a2770d48b, static POWER8 definitions became unnecessary,
as all of them (and much more) are already present in libpmc's
PMU events.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 40724
Build 37613: arc lint + arc unit

Event Timeline

luporl created this revision.Jul 28 2021, 4:54 PM
Herald added a subscriber: imp. · View Herald TranscriptJul 28 2021, 4:54 PM
luporl requested review of this revision.Jul 28 2021, 4:54 PM
Harbormaster completed remote builds in B40724: Diff 92887.Jul 28 2021, 4:54 PM
kbowling accepted this revision.Jul 28 2021, 10:49 PM
This revision is now accepted and ready to land.Jul 28 2021, 10:49 PM
mhorne accepted this revision.Jul 29 2021, 12:28 PM
mhorne added inline comments.
sys/dev/hwpmc/pmc_events.h
1863

Maybe like this?

luporl added inline comments.Jul 29 2021, 5:33 PM
sys/dev/hwpmc/pmc_events.h
1863

Sure.

Closed by commit rG95d619a8ea1f: hwpmc: remove static POWER8 definitions (authored by luporl). · Explain WhyJul 29 2021, 5:57 PM
This revision was automatically updated to reflect the committed changes.
luporl added a commit: rG95d619a8ea1f: hwpmc: remove static POWER8 definitions.
Herald added a reviewer: gnn. · View Herald TranscriptJul 29 2021, 5:57 PM

Revision Contents
Changeset List

PathSize
lib/
libpmc/
21 lines
sys/
dev/
hwpmc/
130 lines
38 lines

Diff 92887

View Options

lib/libpmc/libpmc.c

Loading...
View Options

sys/dev/hwpmc/hwpmc_power8.c

Loading...
View Options

sys/dev/hwpmc/pmc_events.h

Loading...