Don't instrument the rdtsc ifunc when building with ASAN/UBSAN
ClosedPublic
Actions

Authored by arichardson on Jul 5 2021, 10:52 AM.

Details

Reviewers

Commits

rGf0712132b68b: Don't instrument the rdtsc ifunc when building with ASAN/UBSAN

Summary

The ifunc resolver is called before the sanitizer runtime is initialized,
so any instrumentation results in an immediate crash.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 40294
Build 37183: arc lint + arc unit

Event Timeline

arichardson created this revision.Jul 5 2021, 10:52 AM

Herald added a subscriber: imp. · View Herald TranscriptJul 5 2021, 10:52 AM

arichardson requested review of this revision.Jul 5 2021, 10:52 AM

Harbormaster completed remote builds in B40294: Diff 91777.Jul 5 2021, 10:52 AM

arichardson added a parent revision: D31043: Add build system support for ASAN+UBSAN instrumentation.Jul 5 2021, 10:53 AM

arichardson retitled this revision from Don't instrument the rdtsc ifunction when building with ASAN/UBSAN to Don't instrument the rdtsc ifunc when building with ASAN/UBSAN.Jul 5 2021, 1:01 PM

arichardson edited the summary of this revision. (Show Details)

arichardson added a reviewer: kib.

kib accepted this revision.Jul 5 2021, 1:07 PM

This revision is now accepted and ready to land.Jul 5 2021, 1:07 PM

Closed by commit rGf0712132b68b: Don't instrument the rdtsc ifunc when building with ASAN/UBSAN (authored by arichardson). · Explain WhyAug 2 2021, 1:35 PM

This revision was automatically updated to reflect the committed changes.

arichardson added a commit: rGf0712132b68b: Don't instrument the rdtsc ifunc when building with ASAN/UBSAN.

Revision Contents
Changeset List

Path

Size

lib/

libc/

x86/

sys/

Makefile.inc

8 lines

Diff 91777

View Options

lib/libc/x86/sys/Makefile.inc

Don't instrument the rdtsc ifunc when building with ASAN/UBSANClosedPublicActions