rk805: add system poweroff support
ClosedPublic
Actions

Authored by avg on Jun 16 2021, 10:49 AM.

Details

Reviewers

manu
peterj
bz

Commits

rGcc0b35259aed: rk805: add system poweroff support

Summary

On my Rock64 neither EFI nor PSCI shutdown actually power off the board.
RK805 does the job.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 39944
Build 36833: arc lint + arc unit

Event Timeline

avg created this revision.Jun 16 2021, 10:49 AM

Herald added a reviewer: manu. · View Herald TranscriptJun 16 2021, 10:49 AM

Herald added subscribers: emaste, andrew, imp. · View Herald Transcript

avg requested review of this revision.Jun 16 2021, 10:49 AM

Harbormaster completed remote builds in B39929: Diff 90948.Jun 16 2021, 10:49 AM

avg added reviewers: peterj, bz. avg added 1 blocking reviewer(s): manu.Jun 16 2021, 10:51 AM

It's also compatible with rk808 so perfect.

This revision is now accepted and ready to land.Jun 16 2021, 2:02 PM

imp added inline comments.Jun 16 2021, 2:35 PM

sys/arm64/rockchip/rk805.c
865	This cast isn't needed, and could be combined with the device_t dev declaration above.
867	shutdown or power off here?
874	and you don't need two sets of elipses.
945	Why override? Is there some advantage to not trying those methods first?

avg added inline comments.Jun 16 2021, 2:49 PM

sys/arm64/rockchip/rk805.c
865	I just copied the predominant style in the file. But I agree.
867	Both should mean the same in this context.
874	But this is printed (if printed at all) on a separate line.
945	Yes. See the summary / commit message. Maybe it's not entirely clear, but both of those methods not only fail to power off, but they also get stuck until the software watchdog panic-s the system (or invokes ddb).

imp added inline comments.Jun 16 2021, 3:01 PM

sys/arm64/rockchip/rk805.c
867	Except all the other power-off functions in the system say 'power off' because 'shutdown' often means 'while(1);' or similar loop at the end, at least historically.
874	true. You can ignore this.
945	Add add that here explicitly. It's important enough to not be buried in the commit message, I'd think.

address reviews for rk805 poweroff support

Also, rename the shutdown function to poweroff so that it is not
confused with the device_shutdown method.
Always print the "powering off" message (liberate from bootverbose).
If the code still runs after issuing the power-off command then it
failed regardless of whether we had any errors or not.

This revision now requires review to proceed.Jun 17 2021, 7:05 AM

Harbormaster completed remote builds in B39944: Diff 90993.Jun 17 2021, 7:05 AM

manu accepted this revision.Jun 17 2021, 8:00 AM

This revision is now accepted and ready to land.Jun 17 2021, 8:00 AM

peterj accepted this revision.Jun 17 2021, 10:49 AM

Works nice on my RockPro64 board. Thanks!

Closed by commit rGcc0b35259aed: rk805: add system poweroff support (authored by avg). · Explain WhyNov 6 2021, 6:01 PM

This revision was automatically updated to reflect the committed changes.

avg added a commit: rGcc0b35259aed: rk805: add system poweroff support.