Page MenuHomeFreeBSD
Differential D30647

tests/netgraph: Tests for ng_bridge
ClosedPublic
Actions

Authored by donner on Jun 4 2021, 6:55 PM.
Tags
None
Referenced Files
F136153226: D30647.id90474.diff
Sun, Nov 16, 5:53 AM
Unknown Object (File)
Wed, Nov 12, 7:44 AM
Unknown Object (File)
Tue, Nov 11, 3:08 PM
Unknown Object (File)
Sun, Nov 9, 10:15 AM
Unknown Object (File)
Wed, Nov 5, 5:42 PM
Unknown Object (File)
Wed, Nov 5, 1:38 PM
Unknown Object (File)
Wed, Nov 5, 11:52 AM
Unknown Object (File)
Sat, Nov 1, 7:11 PM
View All Files
Subscribers
imp
melifaro

Details

Reviewers
kp
Group Reviewers
network
tests
Commits
rG49736a31a5c2: tests/netgraph: Tests for ng_bridge
rGda49f6099185: tests/netgraph: Tests for ng_bridge
rG1b379f585876: tests/netgraph: Tests for ng_bridge
rG61814702398c: tests/netgraph: Tests for ng_bridge
Summary

Test functionality of ng_bridge(4):

  • replicating traffic to anything but the sending hook
  • persistence
  • detect loops
  • unicast to only one link of many
  • stretch to implementation limits on broadcast
  • uplink in private/classic vlan mode

Depends on D30629

Test Plan
# kyua test bridge
bridge:basic  ->  passed  [0.435s]
bridge:loop  ->  passed  [0.113s]
bridge:many_broadcasts  ->  expected_failure: netgraph queue full (191): 1 checks failed as expected; see output for more details  [12.604s]
bridge:many_unicasts  ->  expected_failure: response too large: 1 checks failed as expected; see output for more details  [54.589s]
bridge:persistence  ->  passed  [0.006s]
bridge:uplink_classic  ->  passed  [0.600s]
bridge:uplink_private  ->  passed  [0.601s]

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 39791
Build 36680: arc lint + arc unit

Event Timeline

donner created this revision.Jun 4 2021, 6:55 PM
Herald added subscribers: melifaro, imp. · View Herald TranscriptJun 4 2021, 6:55 PM
donner requested review of this revision.Jun 4 2021, 6:55 PM
Harbormaster completed remote builds in B39714: Diff 90431.Jun 4 2021, 6:55 PM
donner added reviewers: network, tests.Jun 4 2021, 6:56 PM
donner updated this revision to Diff 90432.Jun 4 2021, 7:23 PM
  • Remove cleanup functions. Does not work as expected.
Harbormaster completed remote builds in B39715: Diff 90432.Jun 4 2021, 7:23 PM
donner updated this revision to Diff 90448.Jun 5 2021, 1:31 PM
  • Test learned unicast
Harbormaster completed remote builds in B39725: Diff 90448.Jun 5 2021, 1:31 PM
donner updated this revision to Diff 90463.Jun 5 2021, 5:13 PM
  • Differentiate the tests by receiving hook expectations
Harbormaster completed remote builds in B39732: Diff 90463.Jun 5 2021, 5:13 PM
donner edited the test plan for this revision. (Show Details)Jun 5 2021, 5:15 PM
donner updated this revision to Diff 90467.Jun 5 2021, 7:03 PM
  • Add tests for uplink in private vlan mode
Harbormaster completed remote builds in B39734: Diff 90467.Jun 5 2021, 7:04 PM
donner edited the summary of this revision. (Show Details)Jun 5 2021, 7:04 PM
donner edited the test plan for this revision. (Show Details)
donner updated this revision to Diff 90470.Jun 5 2021, 10:26 PM
  • Test for uplink in classic mode
Harbormaster completed remote builds in B39737: Diff 90470.Jun 5 2021, 10:26 PM
donner edited the summary of this revision. (Show Details)Jun 5 2021, 10:26 PM
donner edited the test plan for this revision. (Show Details)
donner edited the summary of this revision. (Show Details)
donner updated this revision to Diff 90471.Jun 5 2021, 11:21 PM
  • Add msg_handler in order to receive messages to util.
  • Add tests for the amount of learned mac addresses.
Harbormaster completed remote builds in B39738: Diff 90471.Jun 5 2021, 11:21 PM
donner edited the test plan for this revision. (Show Details)Jun 5 2021, 11:22 PM
donner updated this revision to Diff 90472.Jun 5 2021, 11:43 PM
  • Either expect known problems not related to ng_brigde or pass if they are fixed.
Harbormaster completed remote builds in B39739: Diff 90472.Jun 5 2021, 11:43 PM
donner updated this revision to Diff 90474.Jun 5 2021, 11:50 PM

Depends on D30657

Harbormaster completed remote builds in B39741: Diff 90474.Jun 5 2021, 11:50 PM
donner added a parent revision: D30657: tests/netgraph: Allow receiving answers to messages.Jun 5 2021, 11:51 PM
donner updated this revision to Diff 90563.Jun 8 2021, 9:01 AM
  • Style source
Harbormaster completed remote builds in B39791: Diff 90563.Jun 8 2021, 9:02 AM
kp accepted this revision as: kp.Jun 8 2021, 9:38 AM
This revision is now accepted and ready to land.Jun 8 2021, 9:38 AM
Closed by commit rG61814702398c: tests/netgraph: Tests for ng_bridge (authored by donner). · Explain WhyJun 8 2021, 11:32 AM
This revision was automatically updated to reflect the committed changes.
donner added a commit: rG61814702398c: tests/netgraph: Tests for ng_bridge.
donner added a child revision: D30699: tests/netgraph: Factor out univeral data counter functions.Jun 8 2021, 8:16 PM
donner added a commit: rG1b379f585876: tests/netgraph: Tests for ng_bridge.Jun 15 2021, 12:41 PM
donner added a commit: rGda49f6099185: tests/netgraph: Tests for ng_bridge.Jun 16 2021, 11:46 AM
donner added a commit: rG49736a31a5c2: tests/netgraph: Tests for ng_bridge.Jun 16 2021, 11:51 AM

Revision Contents
Changeset List

PathSize
tests/
sys/
netgraph/
2 lines
654 lines

Diff 90563

View Options

tests/sys/netgraph/Makefile

Loading...
View Options

tests/sys/netgraph/bridge.c

Loading...