Page MenuHomeFreeBSD
Differential D30412

tests/libalias: Factor out common primitives
ClosedPublic
Actions

Authored by donner on May 24 2021, 12:45 PM.
Tags
None
Referenced Files
F173019082: D30412.id89903.diff
Tue, Sep 22, 10:11 PM
Unknown Object (File)
Mon, Sep 21, 7:47 PM
Unknown Object (File)
Thu, Sep 10, 4:44 PM
Unknown Object (File)
Thu, Sep 10, 10:53 AM
Unknown Object (File)
Tue, Sep 8, 2:29 PM
Unknown Object (File)
Tue, Sep 8, 8:58 AM
Unknown Object (File)
Tue, Sep 8, 5:17 AM
Unknown Object (File)
Sun, Sep 6, 11:37 PM
View All Files
Subscribers
asomers
imp
melifaro

Details

Reviewers
kp
lev
Group Reviewers
network
Commits
rG19888502bf39: tests/libalias: Test LibAliasIn and redirection
rG488f39f355ab: tests/libalias: Test LibAliasIn and redirection
rGf1462ab0512c: tests/libalias: Factor out common primitives
Summary

Rework the tests to check the correct layer in a single test.
Factor out tests for reuse in other modules.

Test Plan

make test

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 39375
Build 36264: arc lint + arc unit

Event Timeline

donner created this revision.May 24 2021, 12:45 PM
Herald added subscribers: melifaro, asomers, imp. · View Herald TranscriptMay 24 2021, 12:45 PM
donner requested review of this revision.May 24 2021, 12:45 PM
Harbormaster completed remote builds in B39373: Diff 89717.May 24 2021, 12:45 PM
donner added a reviewer: network.May 24 2021, 12:47 PM
donner mentioned this in D30408: tests/libalias: Test LibAliasIn with redirection.May 24 2021, 1:00 PM
donner added a child revision: D30408: tests/libalias: Test LibAliasIn with redirection.May 24 2021, 1:01 PM
donner updated this revision to Diff 89719.May 24 2021, 1:02 PM
  • Spacing
Harbormaster completed remote builds in B39375: Diff 89719.May 24 2021, 1:02 PM
donner mentioned this in D30405: tests/libalias: Improve testing.May 24 2021, 8:08 PM
donner added a child revision: D30405: tests/libalias: Improve testing.May 24 2021, 8:08 PM
donner updated this revision to Diff 89774.May 24 2021, 8:09 PM

Rebase

Harbormaster completed remote builds in B39412: Diff 89774.May 24 2021, 8:09 PM
This revision was not accepted when it landed; it landed in state Needs Review.May 26 2021, 2:18 PM
Closed by commit rGf1462ab0512c: tests/libalias: Factor out common primitives (authored by donner). · Explain Why
This revision was automatically updated to reflect the committed changes.
donner added a commit: rGf1462ab0512c: tests/libalias: Factor out common primitives.
donner added a commit: rG488f39f355ab: tests/libalias: Test LibAliasIn and redirection.Jun 2 2021, 9:36 AM
donner added a commit: rG19888502bf39: tests/libalias: Test LibAliasIn and redirection.

Revision Contents
Changeset List

PathSize
tests/
sys/
netinet/
libalias/
200 lines
11 lines
77 lines
14 lines

Diff 89719

View Options

tests/sys/netinet/libalias/2_natout.c

Loading...
View Options

tests/sys/netinet/libalias/perf.c

Loading...
View Options

tests/sys/netinet/libalias/util.h

Loading...
View Options

tests/sys/netinet/libalias/util.c

Loading...