IP address parsing in netgraph eating too many characters
ClosedPublic
Actions

Authored by markus_stoffdv.at on Sep 20 2020, 8:40 AM.

Details

Reviewers

Group Reviewers

Commits

rG90e161ec6d11: ng_parse: IP address parsing in netgraph eating too many characters
rG39917ef2a85f: ng_parse: IP address parsing in netgraph eating too many characters
rGf18b7f239dcd: ng_parse: IP address parsing in netgraph eating too many characters
rG63b6a08ce246: ng_parse: IP address parsing in netgraph eating too many characters

Summary

Once the final component of the IP address has been parsed, the offset on the input must not be advanced, as this would remove an unparsed character from the input.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markus_stoffdv.at created this revision.Sep 20 2020, 8:40 AM

Herald added subscribers: melifaro, imp. · View Herald TranscriptSep 20 2020, 8:40 AM

markus_stoffdv.at requested review of this revision.Sep 20 2020, 8:40 AM

I have also filed a corresponding bug a couple of days ago: Bug 249327

afedorov added a subscriber: afedorov.Sep 20 2020, 9:29 AM

After looking at your abandoned review (D26420) where you add parsing of IPv6 addresses. I wondered if we could use the generic inet_aton(3) functions available from kernel space?

P/S. Please add full context to your patches.
svn diff --diff-cmd = diff -x -U999999> change.diff
https://wiki.freebsd.org/Phabricator

Use diff with full context.

In D26489#589559, @afedorov wrote:

After looking at your abandoned review (D26420) where you add parsing of IPv6 addresses. I wondered if we could use the generic inet_aton(3) functions available from kernel space?

I agree, this would probably have been the better than rolling the parser by hand. However, I think the man page leaves some room for improvement regarding it's IPv6 support.

I'm fine with this fix for a special case.
I agree, that a more complete approach would be fine, but this can be done in a later stage.

This revision is now accepted and ready to land.Sep 20 2020, 7:04 PM

bz added a reviewer: network.Oct 31 2020, 7:25 PM

Do you have a committer for this patch?

Closed by commit rG63b6a08ce246: ng_parse: IP address parsing in netgraph eating too many characters (authored by markus_stoffdv.at, committed by donner). · Explain WhyMay 18 2021, 8:40 PM

This revision was automatically updated to reflect the committed changes.

donner added a commit: rG63b6a08ce246: ng_parse: IP address parsing in netgraph eating too many characters.

donner added a commit: rGf18b7f239dcd: ng_parse: IP address parsing in netgraph eating too many characters.Jun 8 2021, 10:16 AM

donner added a commit: rG39917ef2a85f: ng_parse: IP address parsing in netgraph eating too many characters.Jun 8 2021, 10:25 AM

donner added a commit: rG90e161ec6d11: ng_parse: IP address parsing in netgraph eating too many characters.