Page MenuHomeFreeBSD

IP address parsing in netgraph eating too many characters
AcceptedPublic

Authored by markus_stoffdv.at on Sep 20 2020, 8:40 AM.

Details

Summary

Once the final component of the IP address has been parsed, the offset on the input must not be advanced, as this would remove an unparsed character from the input.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

I have also filed a corresponding bug a couple of days ago: Bug 249327

After looking at your abandoned review (D26420) where you add parsing of IPv6 addresses. I wondered if we could use the generic inet_aton(3) functions available from kernel space?

P/S. Please add full context to your patches.
svn diff --diff-cmd = diff -x -U999999> change.diff
https://wiki.freebsd.org/Phabricator

After looking at your abandoned review (D26420) where you add parsing of IPv6 addresses. I wondered if we could use the generic inet_aton(3) functions available from kernel space?

I agree, this would probably have been the better than rolling the parser by hand. However, I think the man page leaves some room for improvement regarding it's IPv6 support.

I'm fine with this fix for a special case.
I agree, that a more complete approach would be fine, but this can be done in a later stage.

This revision is now accepted and ready to land.Sep 20 2020, 7:04 PM