IP address parsing in netgraph eating too many characters

[markus_stoffdv.at]

Summary

Once the final component of the IP address has been parsed, the offset on the input must not be advanced, as this would remove an unparsed character from the input.

[markus_stoffdv.at]

I have also filed a corresponding bug a couple of days ago: Bug 249327

[afedorov]

After looking at your abandoned review (D26420) where you add parsing of IPv6 addresses. I wondered if we could use the generic inet_aton(3) functions available from kernel space?

P/S. Please add full context to your patches.
svn diff --diff-cmd = diff -x -U999999> change.diff
https://wiki.freebsd.org/Phabricator

[markus_stoffdv.at]

Use diff with full context.

[markus_stoffdv.at]

In D26489#589559, @afedorov wrote:

After looking at your abandoned review (D26420) where you add parsing of IPv6 addresses. I wondered if we could use the generic inet_aton(3) functions available from kernel space?

I agree, this would probably have been the better than rolling the parser by hand. However, I think the man page leaves some room for improvement regarding it's IPv6 support.

[donner]

I'm fine with this fix for a special case.
I agree, that a more complete approach would be fine, but this can be done in a later stage.

[donner]

Do you have a committer for this patch?

sys/netgraph/ng_parse.c

for (color = 0; color < 16; ++color) {
 
                         for (j = 0; j < 8; ++j) {
                                 if (!((mask >> (7 - j)) & 0x1))
                                         continue;
 
                                 /* The pixel "j" uses color "color". */
                                 for (plane = 0; plane < 4; ++plane)
                                         planes[i * 4 + plane] |=
-                                            ((color >> plane) & 0x1) << (7 - j);
+                                            ((cons_to_vga_colors[color] >>
+                                            plane) & 0x1) << (7 - j);
                         }
                 }
         }
 
         /*
          * The bytes are ready: we now switch to Write Mode 0 and write
          * all bytes, one plane at a time.
          */