Page MenuHomeFreeBSD
Differential D30009

iflib: Take iri_pad into account when processing small frames
ClosedPublic
Actions

Authored by kd on Apr 27 2021, 10:49 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Apr 6, 7:47 AM
Unknown Object (File)
Fri, Apr 4, 11:12 PM
Unknown Object (File)
Thu, Apr 3, 10:01 AM
Unknown Object (File)
Thu, Mar 20, 10:04 PM
Unknown Object (File)
Feb 25 2025, 2:59 AM
Unknown Object (File)
Feb 22 2025, 12:00 AM
Unknown Object (File)
Feb 20 2025, 11:43 PM
Unknown Object (File)
Jan 25 2025, 11:30 AM
View All 64 Files
Subscribers
ae
melifaro

Details

Reviewers
mw
mmacy
shurd
gallatin
Group Reviewers
iflib
Commits
rGcd945dc08a86: iflib: Take iri_pad into account when processing small frames
Summary

Drivers can specify padding of received frames with iri_pad field.
This can be used to enforce ip alignment by hardware.
Iflib ignores that padding when processing small frames, which renders this feature inoperable.
I found it while writing a driver for a NIC that can ip align received packets.
Note that this doesn't change behavior of existing drivers as they all set iri_pad to 0.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
sys/
net/
4 lines

Diff 88411

View Options

sys/net/iflib.c

bin/nvidia-bug-report.sh bin/nvidia-bug-report.sh
bin/nvidia-debugdump
bin/nvidia-smi
lib/.nvidia/libGL.so lib/.nvidia/libGL.so
lib/.nvidia/libGL.so.1 lib/.nvidia/libGL.so.1
lib/.nvidia/libEGL.so lib/.nvidia/libEGL.so
lib/.nvidia/libEGL.so.1 lib/.nvidia/libEGL.so.1
lib/libGLESv1_CM.so lib/libGLESv1_CM.so
lib/libGLESv1_CM.so.1 lib/libGLESv1_CM.so.1
lib/.nvidia/libGLESv2.so lib/.nvidia/libGLESv2.so
lib/.nvidia/libGLESv2.so.2 lib/.nvidia/libGLESv2.so.2
lib/libnvidia-glcore.so
lib/libnvidia-glcore.so.1
danfeUnsubmitted
Done
Inline Actions

These two lines (lib/libnvidia-glcore.so*) look superfluous now after rP420496 I think.

danfe: These two lines (`lib/libnvidia-glcore.so*`) look superfluous now after rP420496 I think.
cemAuthorUnsubmitted
Not Done
Inline Actions

Good catch, thanks!

cem: Good catch, thanks!
lib/libXvMCNVIDIA.a lib/libXvMCNVIDIA.a
lib/libXvMCNVIDIA.so lib/libXvMCNVIDIA.so
lib/libXvMCNVIDIA.so.1 lib/libXvMCNVIDIA.so.1
lib/libXvMCNVIDIA_dynamic.so.1 lib/libXvMCNVIDIA_dynamic.so.1
lib/libnvidia-cfg.so lib/libnvidia-cfg.so
lib/libnvidia-cfg.so.1 lib/libnvidia-cfg.so.1
lib/libnvidia-eglcore.so lib/libnvidia-eglcore.so
lib/libnvidia-eglcore.so.1 lib/libnvidia-eglcore.so.1
lib/libnvidia-glcore.so lib/libnvidia-glcore.so
lib/libnvidia-glcore.so.1 lib/libnvidia-glcore.so.1
lib/libnvidia-glsi.so lib/libnvidia-glsi.so
lib/libnvidia-glsi.so.1 lib/libnvidia-glsi.so.1
lib/libnvidia-ml.so
lib/libnvidia-ml.so.1
lib/libnvidia-tls.so lib/libnvidia-tls.so
lib/libnvidia-tls.so.1 lib/libnvidia-tls.so.1
lib/libvdpau_nvidia.so lib/libvdpau_nvidia.so
lib/vdpau/libvdpau_nvidia.so.1 lib/vdpau/libvdpau_nvidia.so.1
man/man1/nvidia-smi.1.gz
%%MODULESDIR%%/drivers/nvidia_drv.so %%MODULESDIR%%/drivers/nvidia_drv.so
%%MODULESDIR%%/extensions/.nvidia/libglx.so %%MODULESDIR%%/extensions/.nvidia/libglx.so
%%MODULESDIR%%/extensions/.nvidia/libglx.so.1 %%MODULESDIR%%/extensions/.nvidia/libglx.so.1
/%%KMODDIR%%/nvidia.ko /%%KMODDIR%%/nvidia.ko
/%%KMODDIR%%/nvidia-modeset.ko
%%LINUX%%%%LINUXBASE%%/usr/lib/libEGL.so.%%SHLIB_VERSION%% %%LINUX%%%%LINUXBASE%%/usr/lib/libEGL.so.%%SHLIB_VERSION%%
%%LINUX%%%%LINUXBASE%%/usr/lib/libEGL.so.1 %%LINUX%%%%LINUXBASE%%/usr/lib/libEGL.so.1
%%LINUX%%%%LINUXBASE%%/usr/lib/libEGL_nvidia.so.%%SHLIB_VERSION%%
%%LINUX%%%%LINUXBASE%%/usr/lib/libGL.so.%%SHLIB_VERSION%% %%LINUX%%%%LINUXBASE%%/usr/lib/libGL.so.%%SHLIB_VERSION%%
%%LINUX%%%%LINUXBASE%%/usr/lib/libGL.so.1 %%LINUX%%%%LINUXBASE%%/usr/lib/libGL.so.1
%%LINUX%%%%LINUXBASE%%/usr/lib/libEGL_nvidia.so
%%LINUX%%%%LINUXBASE%%/usr/lib/libEGL_nvidia.so.0
%%LINUX%%%%LINUXBASE%%/usr/lib/libGLESv1_CM.so.%%SHLIB_VERSION%% %%LINUX%%%%LINUXBASE%%/usr/lib/libGLESv1_CM.so.%%SHLIB_VERSION%%
%%LINUX%%%%LINUXBASE%%/usr/lib/libGLESv1_CM.so.1 %%LINUX%%%%LINUXBASE%%/usr/lib/libGLESv1_CM.so.1
%%LINUX%%%%LINUXBASE%%/usr/lib/libGLESv1_CM.so
%%LINUX%%%%LINUXBASE%%/usr/lib/libGLESv1_CM_nvidia.so.1
%%LINUX%%%%LINUXBASE%%/usr/lib/libGLESv1_CM_nvidia.so.%%SHLIB_VERSION%%
%%LINUX%%%%LINUXBASE%%/usr/lib/libGLESv2.so.%%SHLIB_VERSION%% %%LINUX%%%%LINUXBASE%%/usr/lib/libGLESv2.so.%%SHLIB_VERSION%%
%%LINUX%%%%LINUXBASE%%/usr/lib/libGLESv2.so.2 %%LINUX%%%%LINUXBASE%%/usr/lib/libGLESv2.so.2
%%LINUX%%%%LINUXBASE%%/usr/lib/libGLESv2.so
%%LINUX%%%%LINUXBASE%%/usr/lib/libGLESv2_nvidia.so.2
%%LINUX%%%%LINUXBASE%%/usr/lib/libGLESv2_nvidia.so.%%SHLIB_VERSION%%
%%LINUX%%%%LINUXBASE%%/usr/lib/libGLdispatch.so
%%LINUX%%%%LINUXBASE%%/usr/lib/libGLdispatch.so.0
%%LINUX%%%%LINUXBASE%%/usr/lib/libOpenGL.so
%%LINUX%%%%LINUXBASE%%/usr/lib/libOpenGL.so.0
%%LINUX%%%%LINUXBASE%%/usr/lib/libnvidia-glcore.so.%%SHLIB_VERSION%%
danfeUnsubmitted
Done
Inline Actions

This line is bogus (see exactly the same entry on line 61). That's one of the reasons to keep this file sorted. Having it breaks packaging of legacy drivers.

danfe: This line is bogus (see exactly the same entry on line 61). That's one of the reasons to keep…
%%LINUX%%%%LINUXBASE%%/usr/lib/libcuda.so.%%SHLIB_VERSION%% %%LINUX%%%%LINUXBASE%%/usr/lib/libcuda.so.%%SHLIB_VERSION%%
%%LINUX%%%%LINUXBASE%%/usr/lib/libcuda.so.1 %%LINUX%%%%LINUXBASE%%/usr/lib/libcuda.so.1
%%LINUX%%%%LINUXBASE%%/usr/lib/libnvidia-eglcore.so.%%SHLIB_VERSION%% %%LINUX%%%%LINUXBASE%%/usr/lib/libnvidia-eglcore.so.%%SHLIB_VERSION%%
%%LINUX%%%%LINUXBASE%%/usr/lib/libnvidia-glcore.so.%%SHLIB_VERSION%% %%LINUX%%%%LINUXBASE%%/usr/lib/libnvidia-glcore.so.%%SHLIB_VERSION%%
%%LINUX%%%%LINUXBASE%%/usr/lib/libnvidia-glsi.so.%%SHLIB_VERSION%% %%LINUX%%%%LINUXBASE%%/usr/lib/libnvidia-glsi.so.%%SHLIB_VERSION%%
%%LINUX%%%%LINUXBASE%%/usr/lib/libnvidia-tls.so.%%SHLIB_VERSION%% %%LINUX%%%%LINUXBASE%%/usr/lib/libnvidia-tls.so.%%SHLIB_VERSION%%
%%LINUX%%%%LINUXBASE%%/usr/lib/libvdpau.so.%%SHLIB_VERSION%% %%LINUX%%%%LINUXBASE%%/usr/lib/libvdpau.so.%%SHLIB_VERSION%%
%%LINUX%%%%LINUXBASE%%/usr/lib/libvdpau.so.1 %%LINUX%%%%LINUXBASE%%/usr/lib/libvdpau.so.1
%%LINUX%%%%LINUXBASE%%/usr/lib/libvdpau_nvidia.so %%LINUX%%%%LINUXBASE%%/usr/lib/libvdpau_nvidia.so
%%LINUX%%%%LINUXBASE%%/usr/lib/libvdpau_trace.so %%LINUX%%%%LINUXBASE%%/usr/lib/libvdpau_trace.so
%%LINUX%%%%LINUXBASE%%/usr/lib/vdpau/libvdpau_nvidia.so.%%SHLIB_VERSION%% %%LINUX%%%%LINUXBASE%%/usr/lib/vdpau/libvdpau_nvidia.so.%%SHLIB_VERSION%%
%%LINUX%%%%LINUXBASE%%/usr/lib/vdpau/libvdpau_nvidia.so.1 %%LINUX%%%%LINUXBASE%%/usr/lib/vdpau/libvdpau_nvidia.so.1
%%LINUX%%%%LINUXBASE%%/usr/lib/vdpau/libvdpau_trace.so.%%SHLIB_VERSION%% %%LINUX%%%%LINUXBASE%%/usr/lib/vdpau/libvdpau_trace.so.%%SHLIB_VERSION%%
%%LINUX%%%%LINUXBASE%%/usr/lib/vdpau/libvdpau_trace.so.1 %%LINUX%%%%LINUXBASE%%/usr/lib/vdpau/libvdpau_trace.so.1
%%LINUX%%@exec %%LINUXBASE%%/sbin/ldconfig -r %%LINUXBASE%% %%LINUX%%@exec %%LINUXBASE%%/sbin/ldconfig -r %%LINUXBASE%%
%%LINUX%%@unexec %%LINUXBASE%%/sbin/ldconfig -r %%LINUXBASE%% %%LINUX%%@unexec %%LINUXBASE%%/sbin/ldconfig -r %%LINUXBASE%%
%%LINUX%%@dir %%LINUXBASE%%/usr/lib/vdpau
%%LINUX%%@dir %%LINUXBASE%%/usr/lib
%%LINUX%%@dir %%LINUXBASE%%/usr
%%LINUX%%@dir %%LINUXBASE%%
%%LINUX%%@dir /compat